Make bison use reentrant #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashtab.cpp: do not use yaep_free() on memory obtained with operator new().
Required for vnmakarov#12.
Hack for vnmakarov#12 while using the current API.
As a test, eliminate the static global variable anode_cost. Required for vnmakarov#12.
Eliminate all global variables not needed in sread_terminal() or sread_rule(). Required for vnmakarov#12.
Eliminate remaining global variables used by sread_terminal() and sread_rule() by passing parser data via reentrancy hack. Required for vnmakarov#12.
Make sgramm.y compatible with older bison versions.
TheCount
force-pushed
the
feature-reentrant-flexbison
branch
from
697c850 to
f02db90
Compare
TheCount
force-pushed
the
feature-reentrant-flexbison
branch
from
f02db90 to
951188c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #20.
It makes the use of bison (
sgramm.y) reentrant. To this end, it also introduces a method of slipping a pointer to the grammar into the user-providedread_terminal()andread_rule()functions.It brings the tests somewhat closer to reentrancy (
ansic.landansic.y), even though it doesn't affect the library itself.With that, all external dependencies to yaep have been made reentrant. The next steps towards resolving #12 can now concentrate on the core of the library itself.