Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix background of paused blocks in the schedule for safari #172

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

omniskop
Copy link
Contributor

On Safari the background of paused blocks is broken with an inconsistent height. This small change fixes this by specifically setting the background height and brings the look in line with other browsers while not changing their behaviour (testet on chrome and firefox).

Copy link
Member

@saerdnaer saerdnaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saerdnaer saerdnaer closed this Dec 31, 2021
@omniskop
Copy link
Contributor Author

@saerdnaer This is still an issue and the PR would still work 🥺

@saerdnaer
Copy link
Member

saerdnaer commented Dec 27, 2023

Thanks for the reminder! I will have a look why that change got lost...

@saerdnaer saerdnaer reopened this Dec 27, 2023
@saerdnaer saerdnaer merged commit ab5cce3 into voc:master Dec 27, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants