allow audio and video only streams #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know of a service to upload diffs and github seems.. awkward for it. (Only diffs) (Diffs with context) |
|
Thanks for working on this. In general I think audio and video only sources are a sensible concept. However, I'm not sure how this patch is even working for you. It breaks the fundamental assumption that there is a bijection between source id and source name. With this patch applied videomix, audiomix and every thing else have three separate views on the source id. Ideally this would also go along with voctogui changes so audio-only sources aren't offered as video inputs. More generally I'd want voctocore to report an error when setting a video input to a audio-only source and vice versa. |
|
Currently this works for me using multiple audio sources and controlling them by name. I might've missed a commit in the branch. I'll look into it and report back.
…On July 14, 2017 8:12:30 AM GMT-03:00, Florob ***@***.***> wrote:
Thanks for working on this. In general I think audio and video only
sources are a sensible concept.
However, I'm not sure how this patch is even working for you. It breaks
the fundamental assumption that there is a bijection between source id
and source name. With this patch applied videomix, audiomix and every
thing else have three separate views on the source id.
In your setup in particular running `set_audio audio1` will actually
mute all channels, because it sets the audio to source id 3, but only
sources 0 and 1 exist according to audiomix.
You are probably running `set_audio 0`, which is going to go away as
per #98, or relying on changes made in #130.
Ideally this would also go along with voctogui changes so audio-only
sources aren't offered as video inputs. More generally I'd want
voctocore to report an error when setting a video input to a audio-only
source and vice versa.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#128 (comment)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
|
sorry, misread the title |
DavidVentura
force-pushed
the
audio_video_only_streams
branch
from
93635c4 to
5e3989b
Compare
|
@Florob I'll try again and get this working. I "rebased" on top of master, with some changes. Do you think this is the right approach? or would you approach this in some other way? |
|
This PR has not seen any activity for a couple of months and is not mergable. As @Florob mentioned it is not really compatible with the current enumeration schema in the command line protocol. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses part of my performance related "bug" (#127).
It seems that removing the unnecessary streams + the unnecessary generation of videotestsrc and audiotestsrc that were fed to comply with the required caps helps a lot.
I added two options to the config
audio_onlyandvideo_only, which are lists representing which sources do not have audio/video. These are optional and if not present the behavior stays the same as it was until now.When trying to set an audio_only source as video, nothing happens, it will just render the background image if present (black if there's no background feed)
When trying to set a video_only source as audio, there's no audio at all.
PS: My personal config and motivation to do this:
I only get a mixed stream from
video