Crop (second attempt) #179
Conversation
| @@ -185,6 +185,9 @@ | |||
| <property name="homogeneous">True</property> | |||
| </packing> | |||
| </child> | |||
| <style> | |||
There was a problem hiding this comment.
That changes the look of the toolbar?
|
Looks fine code-wise to me, need to run it and play a little with it |
|
Hey @MaKess! Why is the order of the crop attributes top,left,bottom,right instead of left, top, right, bottom (as I would expect it). Is there a special reason for this? |
|
Hi, |
|
Thank you @MaKess. I just found it unusual that way and in my transitions code (see https://github.com/fightling/voctomix-transitions/blob/master/README.md#framecrop) I'm currently using left,top,right,bottom order. |
|
Hi, |
(Second attempt, first merge request can't be reopened…)
This branch adds a cropping element to the pipeline that allows the removal of a superfluous part of the image.
To do this, configuration items for the picture-in-picture and the side-by-side-preview mode were added. For the latter this allows the final mix to be set up for example like illustrated in the following schematic:
The reasoning behind this is, that source B usually shows the speaker who only occupies the middle part of the frame.
From a technical perspective, the cropping of each side of a source is determined by the corresponding newly introduced attribute of the PadState object (croptop, cropleft, cropbottom, cropright). These attributes are set just like xpos, ypos, width and height when choosing a new Mixer state.
If the configuration items are not present in the config file, the four attributes fall back to 0 and no cropping is done. (i.e. the system is backwards compatible and all preexisting config files can still be used)
In a next, still to be implemented, step, this cropping can also be used to remove the black bars from a padded source (4:3 screen grabbing with black bars to fit 16:9 video stream)