Fix audio only sources #350
Conversation
justjanne
commented
Nov 2, 2024
justjanne
commented
- Alsa should be included in the audio only source list
- Don't try to mirror video for audio only sources
- VoctoGUI relies on VideoDisplay to update the audio levels, create an audio only alternative
justjanne
force-pushed
the
fix-audio-only-sources
branch
from
bb340f5 to
997fa29
Compare
|
|
||
| def mute(self, mute): | ||
| self.pipeline.get_by_name("audiosink-{name}".format(name=self.name)).set_property( | ||
| "volume", 1 if mute else 0) |
There was a problem hiding this comment.
Great, this is inverted (but also inverted in videodisplay.py, so let's keep this here as well).
There was a problem hiding this comment.
Tbh, this is just a quick workaround - a better long-term solution would probably be for videodisplay to handle optional audio or optional video itself.
The audioonlysource doesn't show up at all in the video sources on the left, but it does show up in the audio tab on the bottom. It looks just like you'd expect. I'll try to set up the encoder in the next few days again, then I'll be able to attach a screenshot as well. |
|
Atleast for this configuration, [mix]
videocaps=video/x-raw,format=I420,width=1920,height=1080,framerate=25/1,pixel-aspect-ratio=1/1,interlace-mode=progressive,colorimetry=bt709
audiocaps=audio/x-raw,format=S16LE,channels=8,layout=interleaved,rate=48000
sources=cam1,cam2,cam3,slides
livesources=slides
[source.cam1]
kind=decklink
devicenumber=1
video_connection=SDI
video_mode=1080p25
volume=1.0
audio.original = 0+1
[source.cam2]
kind=test
volume=1.0
audio.test = 0+1
[source.cam3]
kind=test
volume=0.0
[source.slides]
kind=decklink
devicenumber=2
video_connection=SDI
video_mode=1080p25
volume=0.0Will try to find out why, if i can't figure it out i might have to revert this. |
|
fixed in 1563f9e - no clue why noone spotted this earlier |
