Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert order of title components #724

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Invert order of title components #724

merged 1 commit into from
Nov 21, 2023

Conversation

ChrisiPK
Copy link
Contributor

@ChrisiPK ChrisiPK commented Sep 4, 2023

This PR inverts the order of the components in the page title. Currently, the page title always begins with the static part media.ccc.de and then shows the dynamic part, i.e. the selected conference/event. This PR puts the dynamic part first and the static part second.

Fixes #723

@saerdnaer saerdnaer self-requested a review September 9, 2023 07:34
@saerdnaer
Copy link
Member

LGTM

@derchrisuk
Copy link
Member

just my 2 cents: this will ruin any search engine listings.
although we don't do any SEO, changing the title attribute will work negatively on any current search engine listings

@manno manno merged commit 3c95f27 into voc:main Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change order of information in page title
4 participants