Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive design SCSS #115

Merged
merged 35 commits into from
Jun 12, 2022
Merged

Responsive design SCSS #115

merged 35 commits into from
Jun 12, 2022

Conversation

noctera
Copy link
Member

@noctera noctera commented May 30, 2022

Status Type
✔️ Ready Refactor

Description

In this new review I have made the frontend responsive, but now with SCSS.

Things to do:

  • Make guide responsive
  • Nav animation (maybe)
  • Carousel for SelectionScreen
  • Logout button not working in MobileTopNav

Motivation and Context

Width this PR the frontend can be used on mobile devices properly.

Screenshots / GIFs (if appropriate):

Checklist

  • I have read the CONTRIBUTING document.
  • I have considered the accessibility of my changes (i.e. did I add proper content descriptions to images, or run my changes with talkback enabled?)
  • I have documented my code if needed

Resolves

@noctera noctera added help wanted Extra attention is needed kind/ui UI changes priority/high labels May 30, 2022
@noctera noctera added this to the v1.3.0 milestone May 30, 2022
@noctera noctera changed the base branch from main to experimental May 30, 2022 09:27
@luwol03
Copy link
Member

luwol03 commented Jun 9, 2022

    • Can we improve the color which is used for all of these texts so that they also work for the dark theme? 2.
    • Can we make the hovered element in a slightly lighter color than the active one?
    • How about making the menu items round and a bit spacing between each items
    image
  1. Cannot scroll on register/login - not able to press the signup button, because it is out of view
  2. Can you please fix the linter

Copy link
Member

@luwol03 luwol03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a maxwidth for the modals on very large screens?

src/App.jsx Outdated Show resolved Hide resolved
src/Components/Nav/MobileTopNav.jsx Show resolved Hide resolved
src/screens/SelectionScreen/SelectionScreen.jsx Outdated Show resolved Hide resolved
src/images/icons/hamburger.svg Show resolved Hide resolved
src/Components/Nav/MobileTopNav.jsx Show resolved Hide resolved
src/hooks/useScrollBlock.js Show resolved Hide resolved
@luwol03 luwol03 merged commit 92a63e3 into experimental Jun 12, 2022
@luwol03 luwol03 deleted the responsive-design-new branch June 12, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed kind/ui UI changes priority/high
Projects
Status: 🚀 Ready
Development

Successfully merging this pull request may close these issues.

3 participants