Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination providers and components #187

Merged
merged 9 commits into from
Sep 6, 2024
Merged

Conversation

elboletaire
Copy link
Member

@elboletaire elboletaire commented Jul 5, 2024

Set as draft until the related API changes are done. When done, this should be upgraded to ensure it works with the latest specification.

vocdoni/interoperability#188

Edit (selankon)

  • Tested and worked
  • Needs new SDK version with pagination (the build will fail until then)

@elboletaire
Copy link
Member Author

To be reviewed: when doing searches we don't have the total number of records (something that will be fixed with the new API changes in theory). Currently what we do is replace the page numbers with a "Previous" and "Next" buttons. But the next button should not be active when there are less results than the total expected in the page (meaning we don't have more pages).

imatge

@selankon selankon marked this pull request as ready for review August 20, 2024 10:21
@selankon selankon marked this pull request as draft August 21, 2024 07:56
@selankon selankon marked this pull request as ready for review September 6, 2024 10:50
On this way it will update selected page faster
@elboletaire elboletaire merged commit 89a5eaf into main Sep 6, 2024
1 check passed
@elboletaire elboletaire deleted the f/pagination-178 branch September 6, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants