-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pagination providers and components #187
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elboletaire
force-pushed
the
f/pagination-178
branch
from
July 5, 2024 08:07
68981e3
to
1d4fa86
Compare
To be reviewed: when doing searches we don't have the total number of records (something that will be fixed with the new API changes in theory). Currently what we do is replace the page numbers with a "Previous" and "Next" buttons. But the next button should not be active when there are less results than the total expected in the page (meaning we don't have more pages). |
selankon
force-pushed
the
f/pagination-178
branch
from
August 20, 2024 09:48
1d4fa86
to
5abd316
Compare
selankon
force-pushed
the
f/pagination-178
branch
from
August 20, 2024 15:02
01968e2
to
94fe768
Compare
selankon
force-pushed
the
f/pagination-178
branch
from
September 6, 2024 10:33
f362e28
to
882d494
Compare
elboletaire
commented
Sep 6, 2024
On this way it will update selected page faster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set as draft until the related API changes are done. When done, this should be upgraded to ensure it works with the latest specification.
vocdoni/interoperability#188
Edit (selankon)