Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: aggregate votes circuit #5

Merged
merged 22 commits into from
Dec 30, 2024
Merged

Conversation

lucasmenendez
Copy link
Contributor

No description provided.

@lucasmenendez lucasmenendez added the enhancement New feature or request label Dec 5, 2024
@lucasmenendez lucasmenendez requested a review from p4u December 5, 2024 09:28
@lucasmenendez lucasmenendez self-assigned this Dec 5, 2024
@lucasmenendez lucasmenendez marked this pull request as ready for review December 18, 2024 07:57
@p4u
Copy link
Member

p4u commented Dec 19, 2024

tests are failing.

@lucasmenendez
Copy link
Contributor Author

tests are failing.

I know, sometimes the inputs hash is not the same in go that in the circuit, I suppose that some values are not in the field of the circuit. But I is not a problem of the circuit, it comes from the test, and the rest of the helpers were needed for the following circuit, so I think that we can merge this PR and solve the test in another issue.

@lucasmenendez lucasmenendez force-pushed the f/aggregate-votes-circuit branch from ca88b45 to d1241bc Compare December 23, 2024 12:43
@p4u
Copy link
Member

p4u commented Dec 23, 2024

We need to find a way to reduce the testing time.

circuits/ballotproof/circom2gnark.go Outdated Show resolved Hide resolved
circuits/aggregator/inputs.go Show resolved Hide resolved
circuits/ballotproof/circom2gnark.go Outdated Show resolved Hide resolved
circuits/voteverifier/inputs.go Show resolved Hide resolved
go.mod Show resolved Hide resolved
@lucasmenendez lucasmenendez merged commit 41d1e4a into main Dec 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants