Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(train): specify num_workers in DataLoader #313

Merged
merged 1 commit into from
Apr 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/so_vits_svc_fork/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import os
from logging import getLogger
from multiprocessing import freeze_support
from pathlib import Path
from typing import Literal

Expand Down Expand Up @@ -819,4 +820,6 @@ def train_cluster(
)


cli()
if __name__ == "__main__":
freeze_support()
cli()
5 changes: 4 additions & 1 deletion src/so_vits_svc_fork/train.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import warnings
from logging import getLogger
from multiprocessing import cpu_count
from pathlib import Path
from typing import Any

Expand Down Expand Up @@ -41,16 +42,18 @@ def __init__(self, hparams: Any):
self.val_dataset = TextAudioDataset(self.__hparams, is_validation=True)

def train_dataloader(self):
# since dataset just reads data from a file, set num_workers to 0
return DataLoader(
self.train_dataset,
# pin_memory=False,
num_workers=min(cpu_count(), 4),
batch_size=self.__hparams.train.batch_size,
collate_fn=self.collate_fn,
)

def val_dataloader(self):
return DataLoader(
self.val_dataset,
# pin_memory=False,
batch_size=1,
collate_fn=self.collate_fn,
)
Expand Down