Add logging #13
Merged
Add logging #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tasuren
requested changes
Mar 17, 2023
voicevox/http.py
Outdated
| @@ -24,8 +31,10 @@ async def request(self, method: str, path: str, **kwargs) -> dict: | |||
| else: | |||
| return response.content | |||
| elif response.status_code == 404: | |||
| logger.debug(response.content) | |||
There was a problem hiding this comment.
ここらへんのログを全部.debugでまとめてresponse = await self.session ...の下に置かない？
そしたら、これからエラーが増えた時にいちいち書かなくて済むし、loggerを標準出力に出すようにしてたときに、.errorとraiseで二重にエラーが出なくて済む。
tasuren
requested changes
Mar 17, 2023
voicevox/http.py
Outdated
| await self.session.aclose() | ||
|
|
||
| async def request(self, method: str, path: str, **kwargs) -> dict: | ||
| response = await self.session.request(method, path, **kwargs) | ||
| logger.debug(response.content) |
There was a problem hiding this comment.
methodとpathもやった方がわかりやすいかも。
後、ステータスコードとか。
リクエストする前にリクエストのログをRequest: {method}: {path}: {kwargs}みたいにして、リクエスト後にレスポンスのログをResponse: {0.status_code}: {0.content}みたいにすれば。
tasuren
previously approved these changes
Mar 18, 2023
tasuren
reviewed
Mar 18, 2023
voicevox/http.py
Outdated
| logger.debug(f"Request: {method} Path: {path} kwargs: {kwargs}") | ||
| response = await self.session.request(method, path, **kwargs) | ||
| logger.debug(f"Response: {response.content}") |
There was a problem hiding this comment.
ステータスコードもあった方がいいんじゃない。
Suggested change
| logger.debug(f"Response: {response.content}") | |
| logger.debug("Response: {0.status_code}: {0.content}".format(response)) |
tasuren
approved these changes
Mar 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.