add luks and lvm install option #161
Conversation
installer.sh.in
Outdated
| @@ -1386,6 +1584,8 @@ menu() { | |||
| "RootPassword" "Set system root password" \ | |||
| "UserAccount" "Set primary user name and password" \ | |||
| "BootLoader" "Set disk to install bootloader" \ | |||
| "Lvm" "Set use of LVM" \ | |||
| "Encryption" "Set encrypted partition" \ | |||
There was a problem hiding this comment.
I feel like these steps should be optional and say they are optional.
The solution will be overkill and possibly wrong for most users.
There was a problem hiding this comment.
Could be.
But the default is, not to use LVM and LUKS, so you can easily click.
What is the best way, make this optional? Form my point, you get more steps to finish the setup.
There was a problem hiding this comment.
Just putting the text "(Optional)" for the menu or section headings
There was a problem hiding this comment.
How about Optional for LVM and Recommended for LUKS? It makes it clear that they are not mandatory, but it encourages the use of encryption.
There was a problem hiding this comment.
I think, the installer shoud bring the topics on the table, so the user can choose or not.
The topic's has many facets and experienced users won't chosse the installer. So no problem to only tag LVM Optional.
pfpulux
force-pushed
the
luks
branch
2 times, most recently
from
4a3a758 to
abc76cd
Compare
|
No objection. |
|
I want to try Void as soon as this is released. :) |
|
You know you can do this during the install if you want to do it manually, but this is still a useful aid. |
Here is a walkthrough https://docs.voidlinux.org/installation/guides/fde.html |
|
This would be a great addition to the installer, thanks! |
|
Really useful, I want to see it in the installer! |
classabbyamp
added
the
installer
|
@pfpulux Would you mind rebasing and resolving the conflict? Not sure what's up with those |
|
What's the status of this feature? Is there a merge conflict? Is it still being considered? Is there a reason it's not in upstream yet? This is a feature I've been considering implementing but I'm unsure if Void devs are interested. |
| @@ -132,6 +134,11 @@ get_option() { | |||
| echo $(grep -E "^${1}.*" $CONF_FILE|sed -e "s|${1}||") | |||
| } | |||
|
|
|||
| a_lt_b() { | |||
There was a problem hiding this comment.
hm so the reason is because they didn't know POSIX has a less than operator, which is presumably why it's not merged. Compat issues. If that's the case then I'll try to get around to doing a refactoring or a rewrite if that's okay with you.
|
i'm personally not interested in adding a complex feature (lvm/luks) to the existing installer when it's already a mess of shell |
fair enough. |
|
I still maintain this patch. Now also allow encrypted Upstream don't has interested, close this now. |
No description provided.