shadow: reduce the number of suid programs #17580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The defaults for what programs contained in shadow have the setuid bit has changed in version 4.7, when using pam most of those tools don't need setuid bits so explicitly disable them. References: * shadow-maint/shadow#199 * https://bugs.archlinux.org/task/64836 * https://bugs.gentoo.org/702252
|
To be clear -- it's not that the defaults have changed, it's that I fixed the build system such that these are actually setuid now. The intention was always that these tools were setuid when It's a damn shame that the setuid becomes implicitly on when shadow is built with PAM. |
This was referenced Jul 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The defaults for what programs contained in shadow have the setuid bit
has changed in version 4.7, when using pam most of those tools don't
need setuid bits so explicitly disable them.
References: