build-style/cargo.sh: add [ci skip] #2837

Cogitri · 2018-09-16T19:40:28Z

supersedes #2436

[ci skip]

common/environment/build-style/cargo.sh

travankor · 2018-09-17T01:19:55Z

Does this work for cross-compiling? I thought cargo needs some coaxing to cross-compile packages?

jnbr · 2018-09-17T11:11:17Z

Cross-compiling can be ignored for now because our rustc builds aren't able to cross-compile.

Cogitri · 2018-09-17T14:47:29Z

Cross-compiling can be ignored for now because our rustc builds aren't able to cross-compile.

Yup, can't test it without being able to cross compile rust. I do plan to work on that in the near future though, I'll add the changes to this build style then (I don't think we should stall this until then though).

travankor · 2018-09-17T20:07:31Z

Can you add a commit documenting this build style in Manual.md, mentioning that nocross should be set for now?

Yup, can't test it without being able to cross compile rust. I do plan to work on that in the near future though, I'll add the changes to this build style then (I don't think we should stall this until then though).

Ok, sounds nice.

maxice8

Please modify Manual.md to include a short explaination of this build_style like it is done with the others.

common/build-style/cargo.sh

Cogitri · 2018-09-18T15:06:12Z

Please modify Manual.md to include a short explaination of this build_style like it is done with the others.

Sure. Seems like work for cross compiling rust is currently being done though, so I'll leave the stuff about nocross out for now

Gottox · 2018-09-20T11:37:16Z

common/environment/build-style/cargo.sh

@@ -0,0 +1 @@
+hostmakedepends+=" cargo rust"


cargo already depends on rust, so we can optimize it away.

common/build-style/cargo.sh

wpbirney · 2018-09-24T15:04:41Z

why not use rustup for the builds so we can enable cross compiling?

Rustup supports a ton of targets and would make cross compiling a breeze

Cogitri · 2018-09-24T15:21:46Z

why not use rustup for the builds so we can enable cross compiling?

Rustup supports a ton of targets and would make cross compiling a breeze

Hm, I'd like to avoid that if possible. With rustup we'd have to download the rust release stuff for every build (I don't think we can save the tarballs in hostdir/sources), which would be rather cumbersome (especially if one's connection is pretty bad). Also, we still need to provide a normal package for rust, some people want a system install of rust (e.g. for development) - although we could (in theory) just repackage rustup's tarballs (not a big fan of that though).

maxice8 · 2018-09-24T16:29:51Z

On Mon, Sep 24, 2018 at 08:06:06AM -0700, Wilson Birney wrote: why not use rustup for the builds so we can enable cross compiling? Rustup supports a ton of targets and would make cross compiling a breeze -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #2837 (comment)

Rustup downloads binaries from outside that is a yuck yuck last resort for us and i am more than willing to wait until Rust people figure out cross-compiling like golang does.

wpbirney · 2018-09-24T21:01:08Z

@maxice8 every rustc is a cross compiler, we could enable the targets in our rustc build and have cross compilation, its in the Config.toml. I have not looked into the template for rustc but will do so tonight

Cogitri · 2018-10-02T00:14:31Z

This enables the use of the cargo buildstyle for all appropriate packages and as such enables cross building for most of them. Depends on #3233. Currently am cross compiling all packages to all arches. Also has the rust commit for cross building in it to make it a little easier to test this, that commit has to be dropped before this gets merged of course.

Cogitri · 2018-10-02T01:20:03Z

Alright, everything but a few packages (which I've marked as broken/nocross) compile for aarch64, testing other platforms...

Gottox · 2018-10-06T21:17:38Z

Manual.md

@@ -734,6 +734,12 @@ The current list of available `build_style` scripts is the following:
 `do_configure()`, `do_build()`, etc., and may overwrite default `do_fetch()` and
 `do_extract()` that fetch and extract files defined in `distfiles` variable.

+- `cargo` For packages written in rust that use Cargo for building. Configuration
+arguments (such as `--features`) can be passed to cargo in `do_build` via
+`configure_args`. Sets the `RUST_TARGET` variable, which can be useful for


Configuration arguments [...] can be passed to cargo in do_build via configure_args.

This looks ambiguous: Could mean you need to pass configure args IN do_build.

Hm, how would you write it? I basically only want to express that one uses configure_args to configure the build (and as such they're used in do_build instead of the usual do_configure)

(Disclaimer: Not a native speaker)

Configuration arguments (such as --features ...) can be defined in the variable configure_args which is applied as command line arguments to cargo during do_build.

Thanks, that does sound better, I'll use something along the lines of that. Did you have a chance to test any of the cross compiled binaries yet?

Changed it, please take a 2nd look at it.

Cogitri · 2018-10-15T09:49:51Z

Also currently testing rust-std splitting, I guess I'll open a PR for that later

Gottox · 2018-10-15T12:08:36Z

Failing on armv7hf-musl:

rustup oxipng amp way-cooler taizen pijul alacritty

Cogitri · 2018-10-15T12:10:07Z

Needs #3798 now

Currently testing all arches with that.

Cogitri · 2018-10-15T12:10:44Z

Failing on armv7hf-musl:

rustup oxipng amp way-cooler taizen pijul alacritty

way-cooler and alacritty already have nocross

Gottox · 2018-10-15T17:57:30Z

Hows testing? :)

Cogitri · 2018-10-15T18:25:33Z

Currently building all packages affected by this PR, armv6l{,-musl} already worked. Should go a lot faster now since the builders have finished building rust rev 4 :)

Cogitri · 2018-10-15T18:33:06Z

Also currently building a rpi3 root FS to test the cross compiled binaries

Ah, that was easier than expected :)

Cogitri · 2018-10-15T18:50:27Z

Alright, at least the aarch64 binaries work AFAICS

Cogitri force-pushed the cargo-buildstyle branch from 9704541 to 0eb8adb Compare September 16, 2018 19:46

maxice8 reviewed Sep 16, 2018

View reviewed changes

common/environment/build-style/cargo.sh Outdated Show resolved Hide resolved

Cogitri force-pushed the cargo-buildstyle branch from 0eb8adb to b13d6ab Compare September 16, 2018 19:57

maxice8 suggested changes Sep 18, 2018

View reviewed changes

maxice8 reviewed Sep 18, 2018

View reviewed changes

common/build-style/cargo.sh Show resolved Hide resolved

Cogitri force-pushed the cargo-buildstyle branch from b13d6ab to bc17b0b Compare September 18, 2018 15:16

maxice8 approved these changes Sep 18, 2018

View reviewed changes

Gottox reviewed Sep 20, 2018

View reviewed changes

common/build-style/cargo.sh Show resolved Hide resolved

common/build-style/cargo.sh Outdated Show resolved Hide resolved

Cogitri mentioned this pull request Sep 30, 2018

rust: cross build (&template cleanup) #3233

Merged

3 tasks

Cogitri force-pushed the cargo-buildstyle branch from bc17b0b to b18dbea Compare October 2, 2018 00:12

Cogitri changed the title ~~build-style/cargo.sh: add~~ build-style/cargo.sh: add [ci skip] Oct 2, 2018

Cogitri force-pushed the cargo-buildstyle branch from b18dbea to 4f1ca8c Compare October 2, 2018 01:19

Cogitri force-pushed the cargo-buildstyle branch 3 times, most recently from 7d35463 to 52b7247 Compare October 2, 2018 18:23

Gottox reviewed Oct 6, 2018

View reviewed changes

Cogitri force-pushed the cargo-buildstyle branch from 52b7247 to b950dfb Compare October 7, 2018 18:42

Gottox mentioned this pull request Oct 8, 2018

add makejobs to cargo based templates [ci skip] #2436

Closed

Rasmus Thomsen added 20 commits October 15, 2018 10:56

rooster: use cargo buildstyle

2058c8d

just: use cargo buildstyle

bac761a

parallel-rust: use cargo buildstyle

5fa577e

alert-after: use cargo buildstyle

2bc1bbb

gutenberg: use cargo buildstyle

d8d1c21

loc: use cargo buildstyle

6e4beb7

hyperfine: use cargo buildstyle

db57e23

servy: use cargo buildstyle

ef73699

fool: use cargo buildstyle

2f6835a

skim: use cargo buildstyle

1144c41

mdBook: use cargo buildstyle

dd082dc

fd: use cargo buildstyle

d7ecb2e

amp: use cargo buildstyle

38b0d0e

rustfmt: use cargo buildstyle

3dd5b86

mdcat: use cargo buildstyle

86d20da

gcsf: use cargo buildstyle

49a4e3c

rustup: use cargo buildstyle

d676ab5

xsv: use cargo buildstyle

4f7cf00

oxipng: use cargo buildstyle

ce11a32

rustup: update to 1.14.0.

08d8058

Cogitri force-pushed the cargo-buildstyle branch from f92d562 to 08d8058 Compare October 15, 2018 08:56

Gottox merged commit d38e0a6 into void-linux:master Oct 15, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build-style/cargo.sh: add [ci skip] #2837

build-style/cargo.sh: add [ci skip] #2837

Cogitri commented Sep 16, 2018 •

edited

Loading

travankor commented Sep 17, 2018

jnbr commented Sep 17, 2018

Cogitri commented Sep 17, 2018

travankor commented Sep 17, 2018

maxice8 left a comment

Cogitri commented Sep 18, 2018

Gottox Sep 20, 2018

wpbirney commented Sep 24, 2018 •

edited

Loading

Cogitri commented Sep 24, 2018

maxice8 commented Sep 24, 2018 via email

wpbirney commented Sep 24, 2018 •

edited

Loading

Cogitri commented Oct 2, 2018 •

edited

Loading

Cogitri commented Oct 2, 2018

Gottox Oct 6, 2018

Cogitri Oct 8, 2018

Gottox Oct 8, 2018 •

edited

Loading

Cogitri Oct 8, 2018

Cogitri Oct 8, 2018

Cogitri commented Oct 15, 2018

Gottox commented Oct 15, 2018

Cogitri commented Oct 15, 2018

Cogitri commented Oct 15, 2018

Gottox commented Oct 15, 2018

Cogitri commented Oct 15, 2018

Cogitri commented Oct 15, 2018 •

edited

Loading

Cogitri commented Oct 15, 2018

build-style/cargo.sh: add [ci skip] #2837

build-style/cargo.sh: add [ci skip] #2837

Conversation

Cogitri commented Sep 16, 2018 • edited Loading

travankor commented Sep 17, 2018

jnbr commented Sep 17, 2018

Cogitri commented Sep 17, 2018

travankor commented Sep 17, 2018

maxice8 left a comment

Choose a reason for hiding this comment

Cogitri commented Sep 18, 2018

Gottox Sep 20, 2018

Choose a reason for hiding this comment

wpbirney commented Sep 24, 2018 • edited Loading

Cogitri commented Sep 24, 2018

maxice8 commented Sep 24, 2018 via email

wpbirney commented Sep 24, 2018 • edited Loading

Cogitri commented Oct 2, 2018 • edited Loading

Cogitri commented Oct 2, 2018

Gottox Oct 6, 2018

Choose a reason for hiding this comment

Cogitri Oct 8, 2018

Choose a reason for hiding this comment

Gottox Oct 8, 2018 • edited Loading

Choose a reason for hiding this comment

Cogitri Oct 8, 2018

Choose a reason for hiding this comment

Cogitri Oct 8, 2018

Choose a reason for hiding this comment

Cogitri commented Oct 15, 2018

Gottox commented Oct 15, 2018

Cogitri commented Oct 15, 2018

Cogitri commented Oct 15, 2018

Gottox commented Oct 15, 2018

Cogitri commented Oct 15, 2018

Cogitri commented Oct 15, 2018 • edited Loading

Cogitri commented Oct 15, 2018

Cogitri commented Sep 16, 2018 •

edited

Loading

wpbirney commented Sep 24, 2018 •

edited

Loading

wpbirney commented Sep 24, 2018 •

edited

Loading

Cogitri commented Oct 2, 2018 •

edited

Loading

Gottox Oct 8, 2018 •

edited

Loading

Cogitri commented Oct 15, 2018 •

edited

Loading