rust: fix musl build

[Cogitri]

No description provided.

[Cogitri]

Currently testing this...

Got further than the builder, but I guess it's better to let this compile once for good.

[Gottox]

I'm test compiling aarch64 atm.

[Gottox]

Native testbuilding afterwards and merging if it succeeds.

[Cogitri]

works for me on x86_64-musl.

=> Creating rust-1.28.0_2.x86_64-musl.xbps for repository /host/binpkgs/rust-cross ...

[Gottox]

okay 👍

[Gottox]

error: cannot produce dylib for `rustc_driver v0.0.0 (file:///builddir/rustc-1.28.0-src/src/librustc_driver)` as the target `aarch64-unknown-linux-musl` does not support these crate types

[Cogitri]

Mind giving uploading the whole log?

[Gottox]

https://gist.github.com/ab75b3796a9383423deecc0828494ac5

[atweiden]

Could this have anything to do with it?

void-packages/srcpkgs/rust/template

Line 151 in 892afb7

--set=target.${_host_triplet}.llvm-config="/usr/bin/llvm-config"

I believe it's erroneously double double-quoted.

[Gottox]

rust-lang/rust#44991

[Gottox]

@atweiden I don't think that makes any difference.

[Cogitri]

I believe it's erroneously double double-quoted.

It doesn't make a difference - although those double quotes are unnecessary.

[Cogitri]

rust-lang/rust#44991

Thanks for liking to that, found it already - currently testing some stuff.

[Gottox]

The error is triggered in cargo afaics:
https://github.com/rust-lang/cargo/blob/master/src/cargo/core/compiler/context/compilation_files.rs#L323

[Gottox]

This function may return the wrong result.

https://github.com/rust-lang/cargo/blob/master/src/cargo/core/compiler/context/compilation_files.rs#L358-L454

[Cogitri]

Hm, curious why no other musl distro (e.g. alpine) carries a patch for that though...

Also, maybe I should just combine this with a rust bump to 1.29.1?

[jnbr]

I think it is just a matter of disabling crt-static for musl - currently testing. We do this for x86_64-musl already. Alpine does this for all architectures.

[Cogitri]

Currently testing with https://git.alpinelinux.org/cgit/aports/plain/community/rust/musl-fix-linux_musl_base.patch

[jnbr]

aarch64-musl build completed with crt_static_default = false. I've set it in src/librustc_target/spec/linux_musl_base.rs, can as well be done in the architecture specific profiles.

[Cogitri]

Alright, mind leaving a patch here then?

[jnbr]

--- rustc-1.28.0-src/src/librustc_target/spec/linux_musl_base.rs.orig   2018-10-08 21:02:21.588611506 +0200
+++ rustc-1.28.0-src/src/librustc_target/spec/linux_musl_base.rs        2018-10-08 21:02:40.846454873 +0200
@@ -61,7 +61,7 @@
     base.post_link_objects_crt.push("crtn.o".to_string());

     // These targets statically link libc by default
-    base.crt_static_default = true;
+    base.crt_static_default = false;
     // These targets allow the user to choose between static and dynamic linking.
     base.crt_static_respected = true;

This is redundant to srcpkgs/rust/files/musl.patch.

[Cogitri]

Testing...

[Cogitri]

Works, thanks @jnbr.

[maxice8]

good to merge ?