-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
element-desktop: update to 1.11.0. #37908
element-desktop: update to 1.11.0. #37908
Conversation
|
ec03de6
to
16dff0e
Compare
Can you update the PR to use electron 19. |
16dff0e
to
96637b8
Compare
@Johnnynator done |
Also needs to be changed in /srcpkgs/element-desktop/files/element-desktop |
... yeah. Building again and trying it out with that changed as well now |
96637b8
to
209e733
Compare
So, since I updated electron element is super slow. Extremely slow. Very much unusable... |
To put some numbers behind that: I'm currently waiting 5 to 15 seconds for switching between chats and even typed characters don't appear right away :/ |
Musl or glibc? Also how is the performance when using upstream electron? |
glibc. How do I try it with upstream electron? Don't know much about electron sadly (or maybe not sadly? :D) |
I've also noticed some crashes, element-desktop crashed on me for the third time now today... |
The issue is specific to our electron19, using the upstream one downloaded from https://github.com/electron/electron/releases/tag/v19.0.8 does not exhibit the same issues. I did probably do most of my tests with a too simple Electron app. |
209e733
to
d25bfc0
Compare
Can you retest with rev 2 of electron19. The issues seem to be fixed at least for me. |
d25bfc0
to
2c93ce2
Compare
Tried with rev2, works as expected, performance problem is gone. |
Testing the changes
The platform support patch has been removed because it's been merged upstream in element-hq/element-desktop#376.
I've tested this locally on x86_64, works as expected.