kore: fix build for Python 3.11 (not ready yet) #39413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgn
force-pushed
the
kore-python-3.11
branch
from
7c02d09
to
cf782f6
Compare
Closed
sgn
force-pushed
the
kore-python-3.11
branch
2 times, most recently
from
40f63f3
to
1ce54dc
Compare
ahesford
reviewed
Sep 22, 2022
sgn
force-pushed
the
kore-python-3.11
branch
from
1ce54dc
to
5c807b7
Compare
sgn
force-pushed
the
kore-python-3.11
branch
from
5c807b7
to
6713975
Compare
ahesford
approved these changes
Sep 22, 2022
| fname = "unknown"; | ||
| } | ||
|
|
||
| +#if PY_VERSION_HEX <= 0x030B0000 |
There was a problem hiding this comment.
It turns out that my previous recommendation for strictly less than is irrelevant because the release version will be 0x030B0F00 and the current RC should be 0x030B0C02, so both are greater than the cutoff anyway. I misread the explanation of the hex versioning scheme and expected the release to be 0x30B00000`.
I'd say make this strictly less than for consistency and mathematical correctness.
|
Imported upstream patch da644a0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes