-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3-Cython: update to 3.0.1. #45086
Conversation
Related: sagemath/sage#29863 I'll have a look into (at least) my pkgs: cypari2, cysignals, fpylll, pplpy, sagemath. I can also have a look into scipy as it's needed for sagemath. Question: could we have cython2 and cython3 coexist for a while? |
The two versions of Cython can't coexist without a lot of pain because they will conflict in the Python package namespace. We can just hold this update until everything is resolved. |
8e70b6b
to
dc86c6c
Compare
pyyaml realeased v6.0.1 which blocks building with Cython 3.0.0 |
Yeah, I'll bump this and patch around it if necessary. |
75dec0e
to
e9e9480
Compare
scipy needs patching to build with pybind 2.11 (or maybe Note that in their main branch they have relaxed the upper bound for cython and pybind11 (they still fix numpy to a particular version). See: https://github.com/scipy/scipy/blob/main/pyproject.toml |
e9e9480
to
f0d038c
Compare
+ compiler_directives={ | ||
+ "binding": True, | ||
+ "embedsignature": True, | ||
+ "language_level": 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+ "language_level": 2 | |
+ "language_level": 2, |
My bad, that's what I get for hand-editing the patch after checking... This should fix it.
f0d038c
to
510b4d4
Compare
7d091a0
to
f53d4ad
Compare
f2643df
to
3d47f7d
Compare
3d47f7d
to
8e6d041
Compare
@tornaria I decided it wasn't worth trying to patch around all of these packages and added a new |
3d45062
to
7fe7229
Compare
I think we have a way forward with sagemath (sagemath/sage#36109 is almost done with review and sagemath/sage#36110 is small). I think it might be possible to have sagemath running on cython 3 within the week. |
7fe7229
to
494d318
Compare
876a445
to
bb84127
Compare
b43e8cc
to
b5700c5
Compare
b5700c5
to
53461a8
Compare
With |
sagemath/sage#36109 was merged a few hours after you merged this, and that is the only "long" part of the move to cython 3. The actual patch needed on top of that to be able to use cython 3 is just 6 lines (plus 19 lines in doctests due to some changed strings). See #45887 for details. |
This is a big update that reflects several years of extensive work, and needs some testing to be sure it doesn't break any Void packages.
Testing the changes
The following packages need to be fixed to build with new Cython: