mupdf: update to 1.23.4.

[triallax]

Testing the changes

• I tested the changes in this PR: YES

[dkwo]

do fbpdf, sioyek, zathura work with this?

[triallax]

Both sioyek and zathura work, didn't test fbpdf.

Edit: actually, sioyek seems to fail to compile...

[Zapeth]

It looks like sioyek needs to be patched for mupdf 1.23 -> ahrm/sioyek#831 (just saw the PR, haven't tested it)

[triallax]

We could do what Alpine does maybe: https://git.alpinelinux.org/aports/tree/community/mupdf/APKBUILD#n109

But not sure if it's worth it.

[dkwo]

the commit msg for sioyek needs changed. also, the patch is not merged upstream. have you tested it?
how urgent is the mupdf update? what does it fix?

[triallax]

the commit msg for sioyek needs changed.

I don't think so, just because it adds a patch doesn't mean it has to have a different commit message. But I'll change it anyway, if you insist. :)

also, the patch is not merged upstream. have you tested it?

I have, it seems to be working fine.

how urgent is the mupdf update? what does it fix?

It's not urgent as far as I know. You can see the changelog for the list of changes and fixes.

[benjcal]

just a quick comment that this broke sioyek for me, but so far for only one PDF

https://ww1.microchip.com/downloads/aemDocuments/documents/MCU08/ProductDocuments/DataSheets/AVR64DD-14-20-Prelim-DataSheet-DS40002444.pdf

I'm able to open it and scroll up and down, but the moment that I open the table of contents and go anywhere sioyek just shows a blank screen.

Reverting to sioyek-2.0.0_4 solved the issue with the PDF in question.

:-)

[Zapeth]

It sounds like this issue in sioyek ahrm/sioyek#539 (comment) which seems like its resolved upstream

You could try to compile it with the fix and PR the patch if it works (or wait for the next release)