Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: ltfs-2.4.6.1 #50845

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

maciozo
Copy link
Contributor

@maciozo maciozo commented Jun 16, 2024

Testing the changes

  • I tested the changes in this PR: briefly

Tested:

  • Listing drives
  • Formatting
  • Mounting drives
  • R/W
  • Unmounting

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

I have not been able to cross-compile this program due to pkgdata complaining about not being able to open its pkgdata.inc file.

=> ltfs-2.4.6.1_1: running do_build ...
make  all-recursive
make[1]: Entering directory '/builddir/ltfs-2.4.6.1'
Making all in messages
make[2]: Entering directory '/builddir/ltfs-2.4.6.1/messages'
Processing bin_mkltfs
genrb number of files: 3
Unable to open or read "/usr/lib64/icu/73.2/pkgdata.inc" option file. status = U_FILE_ACCESS_ERROR
sh: line 1: oma.c: command not found
-- return status = 32512
Failed to compile oma.c
sh: line 1: ./bin_mkltfs.: No such file or directory
-- return status = 32512
Error generating library file. Failed command:   ./bin_mkltfs. ./bin_mkltfs_dat.o
Error generating package data.
make[2]: *** [Makefile:490: libbin_mkltfs_dat.a] Error 1
make[2]: Leaving directory '/builddir/ltfs-2.4.6.1/messages'
make[1]: *** [Makefile:523: all-recursive] Error 1
make[1]: Leaving directory '/builddir/ltfs-2.4.6.1'
make: *** [Makefile:429: all] Error 2
=> ERROR: ltfs-2.4.6.1_1: do_build: '${make_cmd} ${makejobs} ${make_build_args} ${make_build_target}' exited with 2
=> ERROR:   in do_build() at common/build-style/gnu-configure.sh:15

The closest relevant issue I could find to this is linked below, but doing the icu-config tricks mentioned there did not help.
I'd be very appreciative of any suggestions, because I can't see why this program shouldn't be cross-compilable.

LinearTapeFileSystem/ltfs#419

@classabbyamp classabbyamp added the new-package This PR adds a new package label Jun 16, 2024
@maciozo maciozo force-pushed the ltfs-2.4.6.1 branch 3 times, most recently from eb16c7c to 9204ff9 Compare June 16, 2024 14:43
@maciozo
Copy link
Contributor Author

maciozo commented Jun 16, 2024

Thank you so much for your help so far on this, @classabbyamp.

I tried applying the patch you suggested on IRC (LinearTapeFileSystem/ltfs@2db929b).
It no longer works with the current configure.ac, so I modified it slightly:

--- a/configure.ac	2024-06-16 21:48:51.744301806 +0100
+++ b/configure.ac	2024-06-16 21:49:23.842374377 +0100
@@ -337,8 +337,8 @@
 dnl
 dnl Check for ICU
 dnl
-ICU_MODULE_CFLAGS="`icu-config --cppflags 2> /dev/null`";
-ICU_MODULE_LIBS="`icu-config --ldflags 2> /dev/null`";
+ICU_MODULE_CFLAGS="`pkg-config --cflags icu-i18n 2> /dev/null`";
+ICU_MODULE_LIBS="`pkg-config --libs icu-i18n 2> /dev/null`";
 if test -z "$ICU_MODULE_LIBS"
 then
     PKG_CHECK_MODULES([ICU_MODULE], [icu >= 0.21])
@@ -352,16 +352,9 @@
 )
 AC_MSG_RESULT([$icu_6x])
 
-if test "x${icu_6x}" = "xyes"
-then
-    AC_MSG_CHECKING(for ICU version)
-    ICU_MODULE_VERSION="`icu-config --version 2> /dev/null`";
-    if test "${ICU_MODULE_VERSION%%.*}" -ge "60"
-    then
-        AM_EXTRA_CPPFLAGS="${AM_EXTRA_CPPFLAGS} -D ICU6x"
-    fi
-    AC_MSG_RESULT([$ICU_MODULE_VERSION])
-fi
+AC_MSG_CHECKING(for ICU version)
+ICU_MODULE_VERSION="`pkg-config --modversion icu-i18n 2> /dev/null`";
+AC_MSG_RESULT([$ICU_MODULE_VERSION])
 
 dnl
 dnl Check for SNMP

Unfortunately, this still results in the same error.
I did also try without removing the whole if statement around the assignment of ICU_MODULE_VERSION, but the result was the same.

Would it be possible to make it so that this package gets built in qemu, rather than cross-compiling?
It might just be a simpler way out.

@classabbyamp
Copy link
Member

Would it be possible to make it so that this package gets built in qemu, rather than cross-compiling?
It might just be a simpler way out.

there's no way to make that happen in xbps-src/builders

maybe try LinearTapeFileSystem/ltfs#153 (comment) instead. it can be created in the template and go in $XBPS_WRAPPERDIR

Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants