-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nxodejs: fix cross #6573
nxodejs: fix cross #6573
Conversation
aarch64 binaries tested on my RPI3 |
there's a typo in the commit message. Besides, it still fails on armv6l and armv7l. |
Hum, seems like V8 assumes that we build for 32-bit if we compile to a 32-bit platform FWIW, we have to do this due to nodejs/node#21079, their code generation tool links against V8 so we have to build it for the host too (sigh) |
https://github.com/nodejs/node/blob/master/deps/v8/src/base/build_config.h#L149 Seems like we actually have to build nodejs >= 10.9.0 from a i686 host... |
Since all builders are x86_64 and that is not likely to change (especially not to a legacy architecture like i686), that means we just cannot build nodejs for 32 bit arm architectures any more. |
Yup, currently marking it as broken |
1611a78
to
46cbb9d
Compare
Alright, this should work on aarch64* now, but I'll do some more testing - CI and builders seem busy anyway :P |
this will also require removal of nodejs from the armv[67]l* repositories as the builders are currently staging because of nodejs. |
Perhaps disabling the |
I don't think node >=10 has that option anymore and looking at https://github.com/void-linux/void-packages/pull/6573/files#diff-8421a2e1c1611cb3b4ee616adbdd6a15L38 it seems like we did pass that to node. |
Also mark x86_64* -> arm* as broken, we can only build 32bit -> 32bit (i686 -> arm*) , see https://github.com/nodejs/node/blob/master/deps/v8/src/base/build_config.h#L149
Please notify when proposed changes are made |
No description provided.