Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add achievements #2

Closed
rgbkrk opened this issue Mar 20, 2014 · 8 comments
Closed

Add achievements #2

rgbkrk opened this issue Mar 20, 2014 · 8 comments

Comments

@rgbkrk
Copy link

rgbkrk commented Mar 20, 2014

Emit achievement:unlock messages for the achievements package to pick up.

@void-main
Copy link
Owner

Cool package! And I'll definitely integrate it!

@void-main
Copy link
Owner

Is there anyway I can add your package as a dependency in my package in atom? I didn't find the doucmentation...

@rgbkrk
Copy link
Author

rgbkrk commented Mar 20, 2014

There doesn't seem to be a way to use Atom packages as dependencies unless they're on npm as well.

However, achievements doesn't need to be a dependency, as achievements will pick up emitted atom events on its own. What would you need it as a dependency for?

@void-main
Copy link
Owner

What if the user hasn't installed achivements yet?~
在 2014年3月20日 下午8:48,"Kyle Kelley" notifications@github.com写道:

There doesn't seem to be a way to use Atom packages as dependencies unless
they're on npm as well.

However, achievements doesn't need to be a dependency, as achievements
will pick up emitted atom events on its own. What would you need it as a
dependency for?


Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-38162449
.

@void-main
Copy link
Owner

I've added some basic achievements, but there should be more. I'm gonna redesign the way achievement is granted. Thanks for your great package @rgbkrk!

@rgbkrk
Copy link
Author

rgbkrk commented Mar 20, 2014

What if the user hasn't installed achivements yet?

If they don't install it, they don't get achievements. It's opt in so people can install/uninstall/enable/disable as they choose.

I've added some basic achievements, but there should be more. I'm gonna redesign the way achievement is granted. Thanks for your great package @rgbkrk!

Thank you for integrating with it! 😄

@void-main
Copy link
Owner

Hi @rgbkrk, I've pushed the integration to another level by adding an ad for your achievements package. Check it out:

advertisement-for-achievements

I borrowed your achievements-view.coffee file, and make a small hint if the achievements package is not loaded by asking atom.packages. And, you are welcome!

😄

@rgbkrk
Copy link
Author

rgbkrk commented Mar 21, 2014

Hahaha, that's hilarious! Well done sir. 👏 👏

You should use this for this re-sized version (32x32) of the original icon:

v9rd7gr

You could also create that in the view directly in HTML too. ;)

Alternatively, the base64 encoded version, for iconURL:

data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAAABmJLR0QA/wD/AP+gvaeTAAAC5ElEQVRYw+2XTWhUVxTHf+e++96bmTdJZpKJaFRSHUpE1EJRCkFa2i66K7hxXbpx0+KuXXTXZcWlQvddCoWuCsVu3InQVsTSRhJtsMU0xknm+33c4+KNrUkniRuJ0DnwNuedc++P8z/3vPtk9cZ7yh6a2cvNRwAjgBHACOAVB1AHmgHPT2od+N02ObrlneZrbBcP2CGrIF4Jr3gQsGS9h2i6AYB4RbziYQCy7jKadQH5J8+EVRCL6z8GHMavYgozqItx3WXU9Z6LHwqgiBcR1T/Bjp8EwHX/oLVwGc16RPVPsWPHAUibd2kvXkHTJqjiFQ9RnvsclzZp/folpnCAqH4R8QqICUjWb9NZ+hp1/Z0kEFQT4ic3aS9corN0FVs+hlecxZ84iV89Q2fpKp3FK/iV0/gTb4BmiI0ozX6EV6pjbAUAf/w4JqzR+v0ren99h189jQSVLZIOk8AlxCs/Ao7CzDnU9XHJY4KxeTReI9m4k0ubNAYyCYWZc0hQo//oe+zYMcCQrN8h3N8mOnIB41dIVm8MpJGdKvCsEEJQe5viwfP0/vyWrH0fjI9qOmgoRXEgBn/yLcLp9+kuf4PrPwLxQAxiI8RYXNpEXRcJKogJX6ACYghr71Ca/Zj+39fprfwAxsf1VzD+JCacBgVjx3HxGsHUPCaYpHjoPCbcjwlqhPvexQTTqEto37uMLc9RnvsCr3SYdOMuiGwDoA6v9BqlIxcwdoJg6izB5Fm6D6+RNG7hDnxI+fXPQASXNEjXb5O1F0kav4AqwdQ8dvwEafMeptgi3PcBUf0iJpjCxau4eG3T5gCy+UqmGL+CXz0DYgd6CWnrN7LWAl5pFr/yJggkjZ/IOg/ys0/+eNFRvMIM8ZObgMGfOIWNjqIuJln/OY9nR4Ac4j+DQ0yeOND/2YnJ/Vtz9V//rvFDB5HkjTS0OXeb3LK5xLvGv9LfghHACOD/BLCXP6fpYMTtmb3AqHq55j0FPA8aWVLic5oAAAAASUVORK5CYII=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants