增加显示下载进度条的选项 #32
Merged
增加显示下载进度条的选项 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
==========================================
- Coverage 39.58% 36.80% -2.78%
==========================================
Files 8 8
Lines 384 413 +29
==========================================
Hits 152 152
- Misses 218 247 +29
Partials 14 14
Continue to review full report at Codecov.
|
voidint
reviewed
Jun 26, 2020
| @@ -86,9 +86,15 @@ func install(ctx *cli.Context) (err error) { | |||
|
|
|||
| if _, err = os.Stat(filename); os.IsNotExist(err) { | |||
| // 本地不存在安装包，从远程下载并检查校验和。 | |||
| if _, err = pkg.Download(filename); err != nil { | |||
| var fn = pkg.Download | |||
| if ctx.Bool("progress") { | |||
There was a problem hiding this comment.
- 命名果然是困扰程序员的一大难题，如非得有一个命令行的选项，那我可能选择
-vv、-vvv、--debug之类的常见选项名。 - 之前在issue 25有过初步的设想，可能更加偏向于没有选项开关。
| @@ -102,6 +105,39 @@ func (pkg *Package) Download(dst string) (size int64, err error) { | |||
| return size, nil | |||
| } | |||
|
|
|||
| // DownloadWithProgress downloading file form specified url with verbosely progress bar | |||
| @@ -27,6 +30,26 @@ func NewURLUnreachableError(url string, err error) error { | |||
| } | |||
| } | |||
|
|
|||
| func RankedURL() string { | |||
| if tmp := strings.TrimSpace(os.Getenv("G_MIRROR")); len(tmp) > 0 { | |||
There was a problem hiding this comment.
- 代码中内置一个镜像URL也并不太合适。通过环境变量读取一个自定义的镜像地址，已经足够应对中国大陆的网络需求，不想复杂化。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.