Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pydata-sphinx-theme #1139

Merged

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Apr 5, 2022

References

Use https://github.com/pydata/pydata-sphinx-theme for the docs instead of the RTD theme. We will soonish get a dark theme for free with this: pydata/pydata-sphinx-theme#540

Code changes

Just adding a new docs dependency and changing the sphinx theme

User-facing changes

Docs changes:

docs

Coming dark theme:

dark_docs

Backwards-incompatible changes

None

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022

Binder 👈 Launch a Binder on branch martinRenou/voila/use_pydata_sphinx_theme

@martinRenou
Copy link
Member Author

You can try it here: https://voila--1139.org.readthedocs.build/en/1139/

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file voila-tree-classic.ipynb voila-tree-light.ipynb voila-tree-dark.ipynb voila-tree-miami.ipynb basics.ipynb bqplot.ipynb dashboard.ipynb gridspecLayout.ipynb interactive.ipynb ipympl.ipynb ipyvolume.ipynb multiple_widgets.ipynb query-strings.ipynb reveal.ipynb
Render
chromium
actual 114 <- [130 - 153 - 192] -> 324 79 <- [83 - 92 - 110] -> 150 85 <- [88 - 97 - 115] -> 162 79 <- [84 - 93 - 108] -> 149 2854 <- [2925 - 2982 - 3020] -> 3456 2965 <- [3082 - 3213 - 3287] -> 3949 3016 <- [3085 - 3190 - 3194] -> 3597 3091 <- [3120 - 3248 - 3393] -> 3470 2291 <- [2292 - 2321 - 2421] -> 2673 4860 <- [4882 - 4895 - 5021] -> 5694 10338 <- [11524 - 11790 - 11867] -> 11994 7934 <- [7968 - 7969 - 8136] -> 8151 1518 <- [1577 - 1584 - 1606] -> 1621 2767 <- [2842 - 2877 - 3169] -> 3641
expected 3379 <- [3442 - 3517 - 3701] -> 3876 2976 <- [3227 - 3321 - 3421] -> 3604 3608 <- [3623 - 3709 - 3793] -> 3825 4453 <- [4453 - 4523 - 4661] -> 4748 2559 <- [2655 - 2656 - 2660] -> 2674 3982 <- [4079 - 4213 - 4356] -> 4743 12183 <- [18509 - 19553 - 20811] -> 21515 15319 <- [15660 - 15796 - 15912] -> 16056 1517 <- [1920 - 1997 - 2103] -> 2113

❗ Test metadata have changed
--- /dev/fd/63	2022-04-05 15:00:06.637769429 +0000
+++ /dev/fd/62	2022-04-05 15:00:06.637769429 +0000
@@ -4,37 +4,37 @@
     "BENCHMARK_REFERENCE": "actual"
   },
   "browsers": {
-    "chromium": "97.0.4666.0"
+    "chromium": "94.0.4595.0"
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® Platinum 8171M",
+      "brand": "Xeon® E5-2673 v3",
       "cache": {
         "l1d": 65536,
         "l1i": 65536,
-        "l2": 2097152,
-        "l3": 36700160
+        "l2": 524288,
+        "l3": 31457280
       },
       "cores": 2,
       "family": "6",
-      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear",
+      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
       "governor": "",
       "manufacturer": "Intel®",
-      "model": "85",
+      "model": "63",
       "physicalCores": 2,
       "processors": 1,
       "revision": "",
       "socket": "",
-      "speed": 2.6,
+      "speed": 2.4,
       "speedMax": null,
       "speedMin": null,
-      "stepping": "4",
+      "stepping": "2",
       "vendor": "GenuineIntel",
       "virtualization": false,
       "voltage": ""
     },
     "mem": {
-      "total": 7283851264
+      "total": 7291699200
     },
     "osInfo": {
       "arch": "x64",
@@ -42,11 +42,11 @@
       "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.13.0-1017-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
-      "release": "20.04.4 LTS",
-      "serial": "7e6c579d3a17418a828d3432930b702c",
+      "release": "20.04.3 LTS",
+      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
       "servicepack": "",
       "uefi": false
     }

@trungleduc trungleduc added this to the 0.3.x milestone Apr 5, 2022
@trungleduc
Copy link
Member

Thanks @martinRenou !

@trungleduc trungleduc merged commit 9afaaf0 into voila-dashboards:main Apr 6, 2022
@martinRenou martinRenou deleted the use_pydata_sphinx_theme branch April 6, 2022 08:33
@martinRenou
Copy link
Member Author

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants