ticket VG-2882

adding buffer overflow protection for hep data
voipmonitor · Sep 17, 2024 · b77c1c7 · b77c1c7
1 parent 02884a0
commit b77c1c7
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/hep.cpp b/hep.cpp
@@ -33,8 +33,10 @@ void cHEP_ProcessData::processData(u_char *data, size_t dataLen) {
 			if(processed < dataLen) {
 				hep_buffer.add(data + processed, dataLen - processed);
 			}
+		} else {
+			hep_buffer.add(data, dataLen);
 		}
-	} else {
+	} else if(!hep_buffer.empty()) {
 		hep_buffer.add(data, dataLen);
 		if(isCompleteHep(hep_buffer.data(), hep_buffer.data_len())) {
 			unsigned processed = processHeps(hep_buffer.data(), hep_buffer.data_len());
@@ -44,6 +46,10 @@ void cHEP_ProcessData::processData(u_char *data, size_t dataLen) {
 				hep_buffer.removeDataFromLeft(processed);
 			}
 		}
+		if(hep_buffer.size() > 1024 * 1024) {
+			hep_buffer.clear();
+			syslog(LOG_NOTICE, "HEP data exceeded the limit of 1MB. Check the HEP data sent.");
+		}
 	}
 }