Allow setting an explicit database URL (in master) #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
so that's how it's gonna be. It's passing locally, I'll look into it. |
|
Looks like Travis was just having a day: I re-ran the three jobs individually yesterday and they all passed. Just restarted the build to confirm they all still pass OK, and if so, I'll merge this. |
|
Travis is definitely having some issues with Xcode 8: these just fail to build for no reason sometimes. I'll keep an eye on it in future PRs and see if there's anything that might need to change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are all @chillpop commits from #92. I cherry-picked them into a new branch for merge into master.
As long as Travis doesn't have any issues with it, I'm going to merge this, since the code has already been reviewed and tweaked in that previous PR.
@vokal/ios-developers FYI