-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nullable types for PHP 8.4 #208
base: master
Are you sure you want to change the base?
Conversation
PHP 8.4 will be out soon, can we merge this plz ? |
Just trying to get some more attention for this. We are using this in https://github.com/joomla/joomla-cms and currently encounter the problem when updating to PHP 8.4. Merging this and a new release would be really great. |
PHP has been released with 8.4.1 and this issue is still not addressed. |
hey @voku, is there a timeline for getting this reviewed by any chance? Thanks a lot in advance! |
@voku Could you please take a look at this tiny PR, merge it, and create a new tag for it? Shouldn't take more than 5 minutes of your time. Would help a bunch of people. Thanks in advance. |
This change is very much needed, hopefully we see it soon in a release. |
+1 getting this pushed through. I've never seen so many deprecations warnings 😅 |
Here is a tmp workaround to be able to update to PHP 8.4 for now: "repositories": [
{
"type": "package",
"package": {
"name": "voku/portable-utf8",
"version": "6.0.14",
"source": {
"type": "git",
"url": "https://github.com/joomla-backports/portable-utf8.git",
"reference": "joomla-5.3"
}
}
}
] Edit: Here is another approach done by Joomla team itself. P.S: This will install the Joomla team fork of |
Please don't use the fork from the Joomla team. We are not sure if we are going to use that fork and don't plan to support it. We are actually only using it because a dependency of us (wamania/stemmer) is using it and we did provide a PR to that dependency to convert away from portable-utf8 to the Joomla Framework string package instead, which has enough capabilities to replace this library. |
Thank you for clarification. Not supporting it is totally logical and understandable. however as of right now that library does not require any attention and there is no other safe option either. so just please keep it as is for a short period of time until the current MR is merged or an alternative comes up. |
This PR has been open for over 6 months now, and seeing both the repo and @voku's activity, doesn't seem this will get merged anytime soon. An actual maintained fork would be the nice to have instead. |
Fixes
Proposed Changes
This change is