Ignore Composite Foreign Keys. #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulo-raca
force-pushed
the
ignore-composite-fk
branch
from
0a930b2 to
f03a54d
Compare
|
I've updated it with tests for Postgres+MySQL+SQLite3+MS-SQL. |
paulo-raca
force-pushed
the
ignore-composite-fk
branch
2 times, most recently
from
84d21c4 to
9d99317
Compare
Boiler doesn't support composite FKs -- And this is OK. However if there is one on the database, it should ignore it and generate valid code.
paulo-raca
force-pushed
the
ignore-composite-fk
branch
from
9d99317 to
2cb4f9b
Compare
|
@stephenafamo This is pretty exciting and currently blocking us. What's the chance we could get a release cut that includes this fix? Happy to help with that if there's anything I/we can do, too. |
|
The latest release should already include it. Are you still having issues? |
|
We are on 4.15.0 and having issues, but I think this merged a few days after that release shipped. |
|
That's true, I got things mixed up, I haven't done a release in a while. I'll tag a new version. |
|
Wonderful, thank you! |
|
Anything I can do to help get a new release out? |
|
Released now. Apologies for the delay @adsteel |
|
@stephenafamo no problem at all. This is exciting, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boiler doesn't support composite FKs -- And this is OK.
However if there is one on the database, it should ignore it and generate valid code.
This addresses #1298