Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: added --no-schema option scaffolding, needs tests #1414

Merged

Conversation

morganhein
Copy link
Contributor

This adds the --no-schema option, which allows for overriding the default option in the driver.

This flag only allows forcefully ignoring the schema, setting --no-schema=false does not force usage of the schema.

This code works, but I'd like some feedback on what else needs to be updated to make this land.

I don't feel confident deciding which tests to update for this, nor if you'd like README stuffs to be updated.

Any guidance is welcome, and i'll do what I can.

Thanks!

@stephenafamo
Copy link
Collaborator

Kindly fix the new conflicts 🙏🏾

@morganhein morganhein force-pushed the feat/add-no-schema-argument branch from dc42730 to 583bd69 Compare November 12, 2024 16:28
@stephenafamo stephenafamo merged commit dafaf41 into volatiletech:master Nov 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants