Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comment of find library for windows if needed #1512

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented Jan 3, 2025

The Windows library has previously been added to the try block.

The Windows library has previously been added to the try block.
@ikelos
Copy link
Member

ikelos commented Jan 5, 2025

I don't know that this works under windows, I haven't tried it? The FIXME is there to get me to check it? If you've checked that it works under windows, then I'll take it out happily, but otherwise we need to check it at somepoint (and having a FIXME there is a useful reminder).

@j-t-1
Copy link
Contributor Author

j-t-1 commented Jan 5, 2025

Have not run this under Windows. Was thinking (probably wrongly) that the comment was referring to lines 37 and 43. I think the comment could be changed to make it more self-explanatory.

@ikelos
Copy link
Member

ikelos commented Jan 5, 2025

No, you're right, those are the lines it's referring to, I just... never actually tested them. 5:P As soon as someone's confirmed that they've checked it all works right on windows, I'm happy to ditch the FIXME... 5:D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants