Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fails with Japanese punctuation (), strong syntax and code syntax #135

Closed
KSR-Yasuda opened this issue Jul 11, 2022 · 5 comments
Closed

Comments

@KSR-Yasuda
Copy link

KSR-Yasuda commented Jul 11, 2022

It fails syntax handling in below cases:

* ×: あれ、**`foo`これ**、それ
* ○: あれ、 **`foo`これ**、それ
* ×: あれ、**`foo`これ** 、それ

* ○: あれ、**fooこれ**、それ
* ○: あれ、 **fooこれ**、それ
* ○: あれ、**fooこれ** 、それ

MarkdownPreviewPlus_20220711_111707

It looks bad if strong-syntax begins with a code-syntax (i.e **`code` strong**),
and it is surrounded by Japanese punctuation without spaces.

Environment

  • Windows 10 Version 21H2 (Build 19044.1766)
  • Chrome 103.0.5060.114 (Official Build) (64 bits) (cohort: Stable)
  • Markdown Preview Plus v0.7.21
@KSR-Yasuda KSR-Yasuda changed the title [Bug] Fails with Japanese punctuation (), strong syntax (**) and code syntax (` ``) [Bug] Fails with Japanese punctuation (), strong syntax (**) and code syntax ( ) Jul 11, 2022
@KSR-Yasuda KSR-Yasuda changed the title [Bug] Fails with Japanese punctuation (), strong syntax (**) and code syntax ( ) [Bug] Fails with Japanese punctuation (), strong syntax and code syntax Jul 11, 2022
@volca
Copy link
Owner

volca commented Jul 11, 2022

I will check it later. Here's an online demo for GFM rendered

@volca
Copy link
Owner

volca commented Jul 11, 2022

Markdown preview render markdown with marked. I tested marked directly

marked -i test.markdown 

<ul>
<li><p>×: あれ、**<code>foo</code>これ**、それ</p>
</li>
<li><p>○: あれ、 <strong><code>foo</code>これ</strong>、それ</p>
</li>
<li><p>×: あれ、**<code>foo</code>これ** 、それ</p>
</li>
<li><p>○: あれ、<strong>fooこれ</strong>、それ</p>
</li>
<li><p>○: あれ、 <strong>fooこれ</strong>、それ</p>
</li>
<li><p>○: あれ、<strong>fooこれ</strong> 、それ</p>
</li>
</ul>

It doesn't work also.

@KSR-Yasuda
Copy link
Author

Okay, I raised an issue with marked.

@volca
Copy link
Owner

volca commented Jul 12, 2022

I tested with cmark-gfm. It works fine

cmark test.markdown

<ul>
<li>
<p>×: あれ、<strong><code>foo</code>これ</strong>、それ</p>
</li>
<li>
<p>○: あれ、 <strong><code>foo</code>これ</strong>、それ</p>
</li>
<li>
<p>×: あれ、<strong><code>foo</code>これ</strong> 、それ</p>
</li>
<li>
<p>○: あれ、<strong>fooこれ</strong>、それ</p>
</li>
<li>
<p>○: あれ、 <strong>fooこれ</strong>、それ</p>
</li>
<li>
<p>○: あれ、<strong>fooこれ</strong> 、それ</p>
</li>
</ul>

volca added a commit that referenced this issue Jul 13, 2022
@volca
Copy link
Owner

volca commented Jul 13, 2022

For a temp workaround, I changed the rules from

v._punctuation="!\"#$%&'()+\\-.,/:;<=>?@\\[\\]`^{|}~"

to

v._punctuation="!\"#$%&'()+\\-.,/:;<=>?@\\[\\]`^{|}~\u037E\u0387\u055A-\u055F\u0589\u058A\u05BE\u05C0\u05C3\u05C6\u05F3\u05F4\u0609\u060A\u060C\u060D\u061B\u061E\u061F\u066A-\u066D\u06D4\u0700-\u070D\u07F7-\u07F9\u0830-\u083E\u085E\u0964\u0965\u0970\u0AF0\u0DF4\u0E4F\u0E5A\u0E5B\u0F04-\u0F12\u0F14\u0F3A-\u0F3D\u0F85\u0FD0-\u0FD4\u0FD9\u0FDA\u104A-\u104F\u10FB\u1360-\u1368\u1400\u166D\u166E\u169B\u169C\u16EB-\u16ED\u1735\u1736\u17D4-\u17D6\u17D8-\u17DA\u1800-\u180A\u1944\u1945\u1A1E\u1A1F\u1AA0-\u1AA6\u1AA8-\u1AAD\u1B5A-\u1B60\u1BFC-\u1BFF\u1C3B-\u1C3F\u1C7E\u1C7F\u1CC0-\u1CC7\u1CD3\u2010-\u2027\u2030-\u2043\u2045-\u2051\u2053-\u205E\u207D\u207E\u208D\u208E\u2308-\u230B\u2329\u232A\u2768-\u2775\u27C5\u27C6\u27E6-\u27EF\u2983-\u2998\u29D8-\u29DB\u29FC\u29FD\u2CF9-\u2CFC\u2CFE\u2CFF\u2D70\u2E00-\u2E2E\u2E30-\u2E42\u3001-\u3003\u3008-\u3011\u3014-\u301F\u3030\u303D\u30A0\u30FB\uA4FE\uA4FF\uA60D-\uA60F\uA673\uA67E\uA6F2-\uA6F7\uA874-\uA877\uA8CE\uA8CF\uA8F8-\uA8FA\uA8FC\uA92E\uA92F\uA95F\uA9C1-\uA9CD\uA9DE\uA9DF\uAA5C-\uAA5F\uAADE\uAADF\uAAF0\uAAF1\uABEB\uFD3E\uFD3F\uFE10-\uFE19\uFE30-\uFE52\uFE54-\uFE61\uFE63\uFE68\uFE6A\uFE6B\uFF01-\uFF03\uFF05-\uFF0A\uFF0C-\uFF0F\uFF1A\uFF1B\uFF1F\uFF20\uFF3B-\uFF3D\uFF3F\uFF5B\uFF5D\uFF5F-\uFF65"

I will keep looking into the issue at marked also

@volca volca closed this as completed Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants