Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CA certs insert method for webhooks. #2464

Closed
jiangkaihua opened this issue Aug 26, 2022 · 2 comments
Closed

Update CA certs insert method for webhooks. #2464

jiangkaihua opened this issue Aug 26, 2022 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jiangkaihua
Copy link
Contributor

What would you like to be added:

Update CA certs insert method for webhooks.

Why is this needed:

Current method addCaCertForWebhook() only added CA cert for webhooks listed in validatingWebhooksName and mutatingWebhooksName

var (
validatingWebhooksName = []string{
"volcano-admission-service-jobs-validate",
"volcano-admission-service-pods-validate",
"volcano-admission-service-queues-validate",
}
mutatingWebhooksName = []string{
"volcano-admission-service-pods-mutate",
"volcano-admission-service-queues-mutate",
"volcano-admission-service-podgroups-mutate",
"volcano-admission-service-jobs-mutate",
}
)

Which is inconvenient for new webhook registration. For example, when user registered new webhook by arg --enabled-admission, new webhook would not get certs since the original method only go through slices above.
So this pr make addCaCertForWebhook() to go through all webhooks registered in volcano admission by arg --enabled-admission.

@jiangkaihua jiangkaihua added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 26, 2022
@Thor-wl
Copy link
Contributor

Thor-wl commented Aug 27, 2022

/close

@volcano-sh-bot
Copy link
Contributor

@Thor-wl: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants