You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Which is inconvenient for new webhook registration. For example, when user registered new webhook by arg --enabled-admission, new webhook would not get certs since the original method only go through slices above.
So this pr make addCaCertForWebhook() to go through all webhooks registered in volcano admission by arg --enabled-admission.
The text was updated successfully, but these errors were encountered:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
What would you like to be added:
Update CA certs insert method for webhooks.
Why is this needed:
Current method
addCaCertForWebhook()
only added CA cert for webhooks listed invalidatingWebhooksName
andmutatingWebhooksName
volcano/cmd/webhook-manager/app/util.go
Lines 39 to 51 in 74b2114
Which is inconvenient for new webhook registration. For example, when user registered new webhook by arg
--enabled-admission
, new webhook would not get certs since the original method only go through slices above.So this pr make
addCaCertForWebhook()
to go through all webhooks registered in volcano admission by arg--enabled-admission
.The text was updated successfully, but these errors were encountered: