-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] develop process for charts related changes? #323
Comments
One of the solutions that I can think of is:
|
IMO, we should maintainer Charts in volcano, and sync it to volcano-sh/charts when release. |
that would be much better. |
Recorded unschedulable event for gang-scheduling.
So for the convenience of development, should we add the charts code back into volcano repo and sync them into chart repo when releasing? @k82cn @hzxuzhonghu @asifdxtreme ? NOTE: We may generate release yaml as istio does now for a simpler approach, but it might not conflict to the chart support. |
Yes, similar to staging pkg in k8s. |
so what's our next step? |
Sync the latest chart templates into local folder and set up the guidance how and when to sync the latest code back to chart when releasing? |
Opened a new PR to adding helm charts back #334 . Once again, this is used to reduce the complexity of developing new features. We don't need to open seperated PRs for one feature changes now. |
what's next step? |
Update the readme document and setup up the guidance for how & when to sync the templates. |
chart is now in main repo. refer #347 for more requirements |
/kind feature
Background:
Now we have seperated repos for volcano and volcano chart. Considering it's possible that the one feature may change them both at the same time. What is the standard process when developing those features. for example: #165
The text was updated successfully, but these errors were encountered: