Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OverusedFn in proportion should be strict #479

Closed
lminzhw opened this issue Oct 14, 2019 · 2 comments
Closed

OverusedFn in proportion should be strict #479

lminzhw opened this issue Oct 14, 2019 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@lminzhw
Copy link
Contributor

lminzhw commented Oct 14, 2019

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

What happened:

overused := attr.deserved.LessEqual(attr.allocated)

In OverusedFn, the overused means every resource in deserved should be less or equal that in allocated.

What you expected to happen:

But, I think deserved should act as a upperbound, overuse of any resource should lead to the overuse of queue.

Case

queue1: deserved: 0.5 cpu, 10G memory
queue2: deserved: 15.5 cpu, 30G memory

queue1 may allocated 10G memory pod and ignore the limit of 0.5 cpu.

@volcano-sh-bot volcano-sh-bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 14, 2019
@lminzhw
Copy link
Contributor Author

lminzhw commented Oct 14, 2019

/cc wangyuqing4

@hzxuzhonghu
Copy link
Collaborator

You should /cc @wangyuqing4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants