-
Notifications
You must be signed in to change notification settings - Fork 962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete an success pod, will cause volcano recreate an new pod to do repeat task #791
Comments
`
} func (cc *Controller) processNextReq(count uint32) bool {
} func (cc *Controller) syncJob(jobInfo *apis.JobInfo, updateStatus state.UpdateStatusFn) error {
} ` |
@gaopeiliang Yeah, that's the current behavior, we can cache the completed pods and in the sync handler, we ignore them during reconcile. Would appreciate it if you can help. |
Good catch ! We did not check task's status in this case :) |
So, if check the |
hm... I think we should handle this in syncJob func :) |
In this case, we should ignore the delete event. |
👍 , yes; so maybe we only record an event and ignore this action :) |
@k82cn @hzxuzhonghu |
oh, that's ok to me for other options :) Please help to open a PR for that, we can discuss detail there. |
what happen if we ignore all delete pod event ?
maybe it would work ...... |
@gaopeiliang When avoid emit
it will trigger |
what is the meaning delete related job then create again? create an new job? delete job will clean all about in cache .. |
@gaocegege |
Try to address issue volcano-sh#791 It's a draft solution, need further discussion.
Try to address issue volcano-sh#791 It's a draft solution, need further discussion. Signed-off-by: pengli <justdoit.pli@gmail.com>
Try to address issue volcano-sh#791 It's a draft solution, need further discussion. Signed-off-by: pengli <justdoit.pli@gmail.com>
even though it make code not clean |
Try to address issue volcano-sh#791 It's a draft solution, need further discussion. Signed-off-by: pengli <justdoit.pli@gmail.com>
Try to address issue volcano-sh#791 It's a draft solution, need further discussion. Signed-off-by: pengli <justdoit.pli@gmail.com>
Try to address issue volcano-sh#791 It's a draft solution, need further discussion. Signed-off-by: pengli <justdoit.pli@gmail.com>
Try to address issue volcano-sh#791 It's a draft solution, need further discussion. Signed-off-by: pengli <justdoit.pli@gmail.com>
Try to address issue volcano-sh#791 It's a draft solution, need further discussion. Signed-off-by: pengli <justdoit.pli@gmail.com>
Try to address issue volcano-sh#791 It's a draft solution, need further discussion. Signed-off-by: pengli <justdoit.pli@gmail.com>
Try to address issue volcano-sh#791 It's a draft solution, need further discussion. Signed-off-by: pengli <justdoit.pli@gmail.com>
Try to address issue volcano-sh#791 It's a draft solution, need further discussion. Signed-off-by: pengli <justdoit.pli@gmail.com>
Hello 👋 Looks like there was no activity on this issue for last 90 days. |
Closing for now as there was no activity for last 60 days after marked as stale, let us know if you need this to be reopened! 🤗 |
Try to address issue volcano-sh#791 It's a draft solution, need further discussion. Signed-off-by: pengli <justdoit.pli@gmail.com>
Try to address issue volcano-sh#791 It's a draft solution, need further discussion. Signed-off-by: pengli <justdoit.pli@gmail.com>
Try to address issue volcano-sh#791 It's a draft solution, need further discussion. Signed-off-by: pengli <justdoit.pli@gmail.com>
What happened:
when job is running , one pod task successful completed, and delete pod some reason, then another new pod will be create to repeat do same task ....
What you expected to happen:
ignore successful completed delete pod event ,, and not create new same pod....
How to reproduce it (as minimally and precisely as possible):
it will created an new short running pod to do same work
Anything else we need to know?:
Environment:
Volcano Version:
release-0.4
Kubernetes version (use
kubectl version
):1.14
OS (e.g. from /etc/os-release):
ubuntu:16
Kernel (e.g.
uname -a
):Linux 4.9.70-040970-generic
Install tools:
Others:
The text was updated successfully, but these errors were encountered: