Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scheduler): move JobInfo helper functions to method #1343

Merged
merged 6 commits into from
Mar 12, 2021
Merged

fix(scheduler): move JobInfo helper functions to method #1343

merged 6 commits into from
Mar 12, 2021

Conversation

Thrimbda
Copy link
Contributor

@Thrimbda Thrimbda commented Mar 3, 2021 •
edited
Loading

formatted some Doc string

Fixes #1341

@volcano-sh-bot
Copy link
Contributor

Welcome @Thrimbda!

It looks like this is your first PR to volcano-sh/volcano.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 3, 2021
@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 3, 2021
@Thrimbda Thrimbda force-pushed the feat/volc-1341 branch 3 times, most recently from 05c3459 to a306c11 Compare March 3, 2021 12:26
@Thrimbda Thrimbda changed the title fix: move JobInfo helper functions to method fix(scheduler): move JobInfo helper functions to method Mar 3, 2021
@Thrimbda
fix(scheduler): move JobInfo helper functions to method
10475a4 
also formatted several doc strings.

Signed-off-by: Siyuan Wang <c.one@thrimbda.com>
@volcano-sh-bot volcano-sh-bot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 3, 2021
@Thrimbda
Copy link
Contributor Author

Thrimbda commented Mar 3, 2021

Just got in touch with volcano :)
/assign @k82cn PTAL

@volcano-sh-bot
Copy link
Contributor

@Thrimbda: GitHub didn't allow me to assign the following users: PTAL.

Note that only volcano-sh members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Just got in touch with volcano :)
/assign @k82cn PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Thrimbda Thrimbda changed the title fix(scheduler): move JobInfo helper functions to method (WIP)fix(scheduler): move JobInfo helper functions to method Mar 3, 2021
@volcano-sh-bot volcano-sh-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2021
@Thrimbda Thrimbda changed the title (WIP)fix(scheduler): move JobInfo helper functions to method fix(scheduler): move JobInfo helper functions to method Mar 3, 2021
@volcano-sh-bot volcano-sh-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2021
@Thrimbda
Copy link
Contributor Author

Thrimbda commented Mar 3, 2021

sorry, I'm not very familiar with the e2e tests, but the refactor should not change any logic...

PTAL @k82cn

@shinytang6
Copy link
Member

shinytang6 commented Mar 3, 2021 •
edited
Loading

sorry, I'm not very familiar with the e2e tests, but the refactor should not change any logic...

PTAL @k82cn

There's something wrong with that e2e action, never mind. According to the issue, maybe you should also move GetJobMinResources to job_info.go.

Rest LGTM.

@Thrimbda
fix: move GetJobMinResources to JobInfo
0a08217 
Signed-off-by: Siyuan Wang <c.one@thrimbda.com>
@Thrimbda
Copy link
Contributor Author

Thrimbda commented Mar 3, 2021

sure, I've moved it, PTAL @shinytang6

@volcano-sh-bot volcano-sh-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 3, 2021
k82cn
k82cn reviewed Mar 4, 2021
View reviewed changes
pkg/scheduler/api/job_info.go Outdated Show resolved Hide resolved
k82cn
k82cn reviewed Mar 4, 2021
View reviewed changes
pkg/scheduler/api/job_info.go Outdated Show resolved Hide resolved
@Thrimbda
refactor: minor changes
94d2c12 
- make `GetWaitingTime` `extractWaitingTime`
- make `GetPreemptable` `extractPreemptable`
- make `GetRevocableZone` `extractRevocableZone`
- make `GetBudget` `extractBudget`
- remove the parameter of JobInfo::GetMinResources

Signed-off-by: Siyuan Wang <c.one@thrimbda.com>
@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2021
@k82cn
Copy link
Member

k82cn commented Mar 4, 2021

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2021
william-wang
william-wang approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2021
@k82cn
Copy link
Member

k82cn commented Mar 10, 2021

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2021
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2021
@k82cn
Copy link
Member

k82cn commented Mar 10, 2021

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2021
@Thrimbda
Copy link
Contributor Author

does it require to rebase to merge?

@k82cn
Copy link
Member

k82cn commented Mar 11, 2021

does it require to rebase to merge?

Waiting for CI happiness :)

@Thor-wl Thor-wl closed this Mar 12, 2021
@Thor-wl Thor-wl reopened this Mar 12, 2021
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2021
@k82cn
Copy link
Member

k82cn commented Mar 12, 2021

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2021
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, shinytang6, Thrimbda, william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot merged commit b09b8af into volcano-sh:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k82cn k82cn k82cn left review comments

@william-wang william-wang william-wang approved these changes

@shinytang6 shinytang6 shinytang6 approved these changes

Assignees

@william-wang william-wang

@k82cn k82cn

@shinytang6 shinytang6

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move jobInfo help func to member func
6 participants
@Thrimbda @volcano-sh-bot @shinytang6 @k82cn @william-wang @Thor-wl