Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm support crd v1 #1378

Merged
merged 11 commits into from
Mar 24, 2021
Merged

Helm support crd v1 #1378

merged 11 commits into from
Mar 24, 2021

Conversation

zen-xu
Copy link
Contributor

@zen-xu zen-xu commented Mar 23, 2021 •
edited
Loading

fix: #1377

zen-xu added 10 commits March 22, 2021 16:51
@zen-xu
support generate-yaml render crd version with v1 and v1beta1
0e5722f 
Signed-off-by: ZhengYu, Xu <zen-xu@outlook.com>
@zen-xu
upgrade install-helm version to v3.5.3
638e424 
Signed-off-by: ZhengYu, Xu <zen-xu@outlook.com>
@zen-xu
move yaml manifests from templates to crd
b877ef7 
Signed-off-by: ZhengYu, Xu <zen-xu@outlook.com>
@zen-xu
add crd_version value to helm
d5a4ff8 
this will render different version of crd

Signed-off-by: ZhengYu, Xu <zen-xu@outlook.com>
@zen-xu
adapt new helm for generate-yaml
b4411bd 
Signed-off-by: ZhengYu, Xu <zen-xu@outlook.com>
@zen-xu
add CRD_VERSION option to Makefile
18c7d6e 
Signed-off-by: ZhengYu, Xu <zen-xu@outlook.com>
@zen-xu
add symbolic link v1 which ref bases
95bf1a0 
Signed-off-by: ZhengYu, Xu <zen-xu@outlook.com>
@zen-xu
support e2e auto select crd version
c1d2676 
Signed-off-by: ZhengYu, Xu <zen-xu@outlook.com>
@zen-xu
fix CRD_VERSION with quotation
97a87d6 
Signed-off-by: ZhengYu, Xu <zen-xu@outlook.com>
@zen-xu
update volcano-development.yaml
22d0d1e 
Signed-off-by: ZhengYu, Xu <zen-xu@outlook.com>
@volcano-sh-bot volcano-sh-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 23, 2021
@zen-xu zen-xu closed this Mar 23, 2021
@zen-xu zen-xu reopened this Mar 23, 2021
@zen-xu zen-xu closed this Mar 23, 2021
@zen-xu zen-xu reopened this Mar 23, 2021
@Thor-wl
Copy link
Contributor

Thor-wl commented Mar 24, 2021

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2021
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Thor-wl, zen-xu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2021
@volcano-sh-bot volcano-sh-bot merged commit 173f3fa into volcano-sh:master Mar 24, 2021
@zen-xu zen-xu mentioned this pull request Mar 31, 2021
Merged
@zen-xu zen-xu deleted the helm-crd-v1 branch April 6, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@Thor-wl Thor-wl Awaiting requested review from Thor-wl

Assignees

@Thor-wl Thor-wl

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to install Volcano v1beta1 CRD with Kubernetes over v1.18
5 participants
@zen-xu @Thor-wl @volcano-sh-bot @jiangkaihua @k82cn