-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add jobflow desgin docs #2339
add jobflow desgin docs #2339
Conversation
@@ -0,0 +1,184 @@ | |||
apiVersion: flow.volcano.sh/v1alpha1 | |||
kind: JobTemplate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you give some description about the difference between vcjob
and jobTemplate
? According to the example, it maybe a little bit redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The jobtemplate exists as a template for vcjob, the main reason is that directly creating a vcjob will be processed by the vcjob controller. Secondly, if vcjob is used to directly add fields to be referenced by jobflow, then the controller logic will be partially moved to jobcontroller, which cannot be better decoupled. And the vcjob does not support being referenced by multiple jobflows and needs to be created repeatedly. Using jobtemplate allows the same jobtemplate to be reused by multiple jobflows. And it supports field modification of the referenced jobtemplate directly in jobflow.
Signed-off-by: zhoumingcheng <zhoumingcheng@beyondcent.com>
19c8e54
to
6eb9439
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Thor-wl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: zhoumingcheng zhoumingcheng@beyondcent.com