Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jobflow desgin docs #2339

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Conversation

zhoumingcheng
Copy link
Contributor

Signed-off-by: zhoumingcheng zhoumingcheng@beyondcent.com

@volcano-sh-bot volcano-sh-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 7, 2022
@@ -0,0 +1,184 @@
apiVersion: flow.volcano.sh/v1alpha1
kind: JobTemplate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give some description about the difference between vcjob and jobTemplate? According to the example, it maybe a little bit redundant.

Copy link
Contributor Author

@zhoumingcheng zhoumingcheng Jul 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The jobtemplate exists as a template for vcjob, the main reason is that directly creating a vcjob will be processed by the vcjob controller. Secondly, if vcjob is used to directly add fields to be referenced by jobflow, then the controller logic will be partially moved to jobcontroller, which cannot be better decoupled. And the vcjob does not support being referenced by multiple jobflows and needs to be created repeatedly. Using jobtemplate allows the same jobtemplate to be reused by multiple jobflows. And it supports field modification of the referenced jobtemplate directly in jobflow.

Signed-off-by: zhoumingcheng <zhoumingcheng@beyondcent.com>
@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2022
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Thor-wl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2022
@volcano-sh-bot volcano-sh-bot merged commit 1b26306 into volcano-sh:master Jul 25, 2022
@zhoumingcheng zhoumingcheng deleted the jobflow-desgin branch January 31, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants