Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create base image for admission service #284

Merged
merged 1 commit into from
Jul 4, 2019

Conversation

TommyLike
Copy link
Contributor

@TommyLike TommyLike commented Jul 3, 2019

Now we would build admission service image from ground in our CI workflow, this patch creates a base image which consists of the installation of required libraries for admission service. This can improve the performance when testing.

For #282

image name: volcanosh/vk-admission-base

image content:

Sending build context to Docker daemon  9.216kB
Step 1/4 : FROM alpine:latest
 ---> 055936d39205
Step 2/4 : ARG KUBE_VERSION="1.13.1"
 ---> Running in 9a9a54338322
Removing intermediate container 9a9a54338322
 ---> 8e7e7a086e00
Step 3/4 : RUN apk add --update ca-certificates &&     apk add --update openssl &&     apk add --update -t deps curl &&     curl -L https://storage.googleapis.com/kubernetes-release/release/v$KUBE_VERSION/bin/linux/amd64/kubectl -o /usr/local/bin/kubectl &&     chmod +x /usr/local/bin/kubectl &&     apk del --purge deps &&     rm /var/cache/apk/*
 ---> Running in 00a41be6c337
fetch http://dl-cdn.alpinelinux.org/alpine/v3.9/main/x86_64/APKINDEX.tar.gz
fetch http://dl-cdn.alpinelinux.org/alpine/v3.9/community/x86_64/APKINDEX.tar.gz
(1/1) Installing ca-certificates (20190108-r0)
Executing busybox-1.29.3-r10.trigger
Executing ca-certificates-20190108-r0.trigger
OK: 6 MiB in 15 packages
(1/1) Installing openssl (1.1.1b-r1)
Executing busybox-1.29.3-r10.trigger
OK: 7 MiB in 16 packages
(1/5) Installing nghttp2-libs (1.35.1-r0)
(2/5) Installing libssh2 (1.8.2-r0)
(3/5) Installing libcurl (7.64.0-r2)
(4/5) Installing curl (7.64.0-r2)
(5/5) Installing deps (0)
Executing busybox-1.29.3-r10.trigger
OK: 8 MiB in 21 packages
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 37.4M  100 37.4M    0     0   550k      0  0:01:09  0:01:09 --:--:--  522k
(1/5) Purging deps (0)
(2/5) Purging curl (7.64.0-r2)
(3/5) Purging libcurl (7.64.0-r2)
(4/5) Purging nghttp2-libs (1.35.1-r0)
(5/5) Purging libssh2 (1.8.2-r0)
Executing busybox-1.29.3-r10.trigger
OK: 7 MiB in 16 packages
Removing intermediate container 00a41be6c337
 ---> 94ff3774735c
Step 4/4 : ENTRYPOINT []
 ---> Running in e460e1ac0f47
Removing intermediate container e460e1ac0f47
 ---> bbadada24a40
Successfully built bbadada24a40
Successfully tagged volcanosh/vk-admission-base:latest

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 3, 2019
@k82cn
Copy link
Member

k82cn commented Jul 4, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, TommyLike

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2019
@volcano-sh-bot volcano-sh-bot merged commit b22847b into volcano-sh:master Jul 4, 2019
kevin-wangzefeng pushed a commit that referenced this pull request Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants