Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed the token-permission and pinned dependencies issue #3689

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: fixed the token-permission and pinned dependencies issue #3689

wants to merge 2 commits into from

Conversation

harshitasao
Copy link
Contributor

fixed the token-permission and pinned dependencies issue reported by scorecard.

Part of #3688

@harshitasao
fix: fixed the token-permission and pinned dependencies issue
85caa35 
Signed-off-by: harshitasao <harshitasao@gmail.com>
@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 22, 2024
@harshitasao harshitasao mentioned this pull request Aug 22, 2024
Open
6 tasks
lowang-bh
lowang-bh reviewed Aug 23, 2024
View reviewed changes
Copy link
Member

@lowang-bh lowang-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2024
@lowang-bh
Copy link
Member

Hi, @harshitasao there is CI failed.

@harshitasao
made required changes to pass CI test
22c8fed 
Signed-off-by: harshitasao <harshitasao@gmail.com>
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2024
@volcano-sh-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign lowang-bh
You can assign the PR to them by writing /assign @lowang-bh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lowang-bh
Copy link
Member

Hi @harshitasao ,please squash commits to only one. thanks.

@Monokaix
Copy link
Member

Monokaix commented Sep 5, 2024

Hi @harshitasao ,please squash commits to only one. thanks.

+1

@volcano-sh-bot volcano-sh-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2024
@volcano-sh-bot
Copy link
Contributor

@harshitasao: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Monokaix
Copy link
Member

Hi, please rebase the master and resolve code conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lowang-bh lowang-bh lowang-bh left review comments

@hwdef hwdef Awaiting requested review from hwdef

At least 1 approving review is required to merge this pull request.

Assignees

@lowang-bh lowang-bh

Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harshitasao @lowang-bh @volcano-sh-bot @Monokaix