Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register healthz interface for controller and scheduler #446

Merged
merged 1 commit into from
Sep 12, 2019

Conversation

sivanzcw
Copy link
Contributor

Add a health check interface to the controller and scheduler components. The cluster needs to determine whether the components in the cluster are healthy through the health check interface. Just as the kube-apiserver provides the health status of the controller-manager and kube-scheduler through the componentStatus interface. When the volcano is deployed in the cluster, the health status of the component may also be reported to the kube-apiserver.

@volcano-sh-bot volcano-sh-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 11, 2019
@TravisBuddy
Copy link

Travis tests have failed

Hey @sivanzcw,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 26d99f50-d496-11e9-847a-07722ef8bbdd

@k82cn
Copy link
Member

k82cn commented Sep 11, 2019

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, sivanzcw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2019
@k82cn
Copy link
Member

k82cn commented Sep 12, 2019

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2019
@volcano-sh-bot volcano-sh-bot merged commit 51132ff into volcano-sh:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants