Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Umbrealla cleanups #511

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Conversation

wangyuqing4
Copy link
Contributor

#402
After kube-batch in-tree and inroducing v1alpha2, there are many import pkgs alias and varialbe names out of date.

  1. scheduler.yaml/volcano-development.yaml delete the same configuration

  2. fix pkg/controllers、pkg/scheduler、pkg/admission、pkg/cli、test/e2e, kb/vk ==> vc

@volcano-sh-bot volcano-sh-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 6, 2019
@wangyuqing4
Copy link
Contributor Author

wangyuqing4 commented Nov 6, 2019

@hzxuzhonghu #402 please help to review :)

@TravisBuddy
Copy link

Hey @wangyuqing4,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: e4670bb0-007a-11ea-8767-d53e6939ac53

@k82cn
Copy link
Member

k82cn commented Nov 6, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, wangyuqing4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2019
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2019
@hzxuzhonghu
Copy link
Collaborator

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2019
@TravisBuddy
Copy link

Hey @wangyuqing4,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: cdfcb460-010b-11ea-82f1-cf3ba55cf6d0

@volcano-sh-bot volcano-sh-bot merged commit 8c29a3e into volcano-sh:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants