Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify job pvc create process #544

Merged
merged 4 commits into from
Nov 21, 2019
Merged

Simplify job pvc create process #544

merged 4 commits into from
Nov 21, 2019

Conversation

hzxuzhonghu
Copy link
Collaborator

This is to simplify createJobIOIfNotExist and fix some unreasonable logic, like job.Status.ControlledResources["volume-emptyDir-"+vcName] = vcName.

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 21, 2019
@k82cn
Copy link
Member

k82cn commented Nov 21, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2019
@TravisBuddy
Copy link

Hey @hzxuzhonghu,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 8f528d60-0c15-11ea-9cd6-8f216fa7db85

@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2019
@volcano-sh-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@volcano-sh-bot volcano-sh-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 21, 2019
k82cn
k82cn reviewed Nov 21, 2019
View reviewed changes
test/e2e/job_controlled_resource.go
@@ -26,47 +26,6 @@ import (
)

var _ = Describe("Job E2E Test: Test Job PVCs", func() {
It("Generate PVC name if not specified", func() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why delete this case?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the behavior: previously if only MountPath defined under JobSpec.Volumes, job controller will create an emptydir pvc for it. This is unreasonable behavior, emptydir is not suggested to be used in production. Also volcano users will not use it, if they really need , they should declare it explicitly. We don't want to set too many default values for it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And i will update the api doc in a following pr.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emptydir is not suggested to be used in production

by k8s community?

@TravisBuddy
Copy link

Hey @hzxuzhonghu,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 48c6d920-0c36-11ea-9489-798921b627f8

@hzxuzhonghu hzxuzhonghu added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2019
@volcano-sh-bot volcano-sh-bot merged commit b34b3f8 into volcano-sh:master Nov 21, 2019
@hzxuzhonghu hzxuzhonghu deleted the job-pvc branch November 21, 2019 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k82cn k82cn k82cn left review comments

@hex108 hex108 Awaiting requested review from hex108

@yuanchen8911 yuanchen8911 Awaiting requested review from yuanchen8911

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hzxuzhonghu @k82cn @volcano-sh-bot @TravisBuddy