Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update scripts as per docker image #78

Merged
merged 2 commits into from
Apr 8, 2019
Merged

Update scripts as per docker image #78

merged 2 commits into from
Apr 8, 2019

Conversation

asifdxtreme
Copy link
Contributor

Fixes #72

@TommyLike
Copy link
Contributor

lgtm

k82cn
k82cn reviewed Apr 8, 2019
View reviewed changes
Makefile Outdated
@@ -1,6 +1,6 @@
BIN_DIR=_output/bin
BIN_OSARCH=linux/amd64
IMAGE=volcanosh/volcano
IMAGE=volcanosh/vk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/IMAGE/IMAGE_PREFIX/g

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@k82cn k82cn merged commit 3348790 into master Apr 8, 2019
@k82cn k82cn deleted the updateimg branch April 8, 2019 09:50
kevin-wangzefeng pushed a commit to kevin-wangzefeng/volcano that referenced this pull request Apr 30, 2019
Merge pull request volcano-sh#78 from volcano-sh/updateimg
d4d8233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k82cn k82cn k82cn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The docker image name should align with binaries'
3 participants
@asifdxtreme @TommyLike @k82cn