Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipped task if no candidate nodes. #843

Merged
merged 1 commit into from
Jun 7, 2020

Conversation

k82cn
Copy link
Member

@k82cn k82cn commented May 31, 2020

fix #838

Signed-off-by: Klaus Ma klaus1982.cn@gmail.com

Signed-off-by: Klaus Ma <klaus1982.cn@gmail.com>
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 31, 2020
@hzxuzhonghu
Copy link
Collaborator

The real cause is from node = util.SelectBestNode(nodeScores), where nodeScores is empty.

@k82cn
Copy link
Member Author

k82cn commented Jun 1, 2020

The real cause is from node = util.SelectBestNode(nodeScores), where nodeScores is empty.

The nodeScores is built from candidateNodes.

@hzxuzhonghu
Copy link
Collaborator

@zishen added a customized plugin, which functions on PrioritizeNodes

@k82cn
Copy link
Member Author

k82cn commented Jun 1, 2020

@zishen added a customized plugin, which functions on PrioritizeNodes

xref #838 (comment)

@hzxuzhonghu
Copy link
Collaborator

Please note: It is possible when candidateNodes is not empty but nodeScores is.

@k82cn
Copy link
Member Author

k82cn commented Jun 1, 2020

Please note: It is possible when candidateNodes is not empty but nodeScores is.

when? PrioritizeNodes should only sort candidateNodes.

@hzxuzhonghu
Copy link
Collaborator

@zishen Please help explain your use case. I remember that batchFn fails, and returns

	batchNodeScore, err := batchFn(task, nodes)
	if err != nil {
		klog.Errorf("Error in Calculating batch Priority for the node, err %v", err)
		return nodeScores
	}

@k82cn k82cn added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2020
@volcano-sh-bot volcano-sh-bot merged commit f115861 into volcano-sh:master Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Observed a panic: invalid argument to Intn(when batchNodeOrder function return err)
3 participants