add e2e cases for preempt #892
Conversation
Signed-off-by: Thor <1187526662@qq.com>
Signed-off-by: Thor <1187526662@qq.com>
Signed-off-by: Thor <1187526662@qq.com>
Signed-off-by: Thor <1187526662@qq.com>
volcano-sh-bot
added
the
size/L
Travis tests have failedHey @Thor-wl, TravisBuddy Request Identifier: a83cfd20-bace-11ea-bd85-f15c2d376ac7 |
Signed-off-by: Thor <1187526662@qq.com>
Travis tests have failedHey @Thor-wl, TravisBuddy Request Identifier: 2bce03e0-bada-11ea-bd85-f15c2d376ac7 |
| @@ -604,7 +513,7 @@ var _ = Describe("Job E2E Test", func() { | |||
| if expectPod%1 == 1 { | |||
| expectPod-- | |||
| } | |||
| err = wait.Poll(100*time.Millisecond, oneMinute, func() (bool, error) { | |||
| err = wait.Poll(100*time.Millisecond, twoMinute, func() (bool, error) { | |||
There was a problem hiding this comment.
Why change this, how come the scheduling is so slow?
There was a problem hiding this comment.
It seems to be releated the cluster environment at that time.It will be timeout in rare cases. I've tried serval times and it woks well after set the timeout to be 2 minutes.
| @@ -700,7 +609,7 @@ var _ = Describe("Job E2E Test", func() { | |||
| if expectPod%1 == 1 { | |||
| expectPod-- | |||
| } | |||
| err = wait.Poll(100*time.Millisecond, oneMinute, func() (bool, error) { | |||
| err = wait.Poll(100*time.Millisecond, twoMinute, func() (bool, error) { | |||
| ctx := initTestContext(options{ | ||
| priorityClasses: map[string]int32{ | ||
| masterPriority: masterPriorityValue, | ||
| workerPriority: workerPriorityValue, |
There was a problem hiding this comment.
suggest fix them in a separate pr, maybe call high/lowPriority
There was a problem hiding this comment.
OK, i will fix the name in next pr
There was a problem hiding this comment.
it has been fixed at #893
| MinMember: 1, | ||
| MinResources: &thirtyCPU, | ||
| }, | ||
| Status: schedulingv1beta1.PodGroupStatus{ |
There was a problem hiding this comment.
remove, create will ignore status.
There was a problem hiding this comment.
it has been fixed at #893
| }, | ||
| Spec: schedulingv1beta1.PodGroupSpec{ | ||
| MinMember: 1, | ||
| MinResources: &thirtyCPU, |
There was a problem hiding this comment.
donot hard coded , should calculate according to the cluster resource
There was a problem hiding this comment.
Good advice. There are lots of hard coded in e2e cases and we need a adequate review later
hzxuzhonghu
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: Thor-wl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.