Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add drf e2e cases #905

Merged
merged 3 commits into from
Jul 6, 2020
Merged

add drf e2e cases #905

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf8c168
add drf e2e cases
Jul 4, 2020
a3d2aac
add copyright for test/e2e/drf.go
Thor-wl Jul 6, 2020
9393648
change or add new file copyright and add comment for drf e2e case
Thor-wl Jul 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions test/e2e/drf.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
package e2e
Thor-wl marked this conversation as resolved.
Show resolved Hide resolved

import (
. "github.com/onsi/ginkgo"
. "github.com/onsi/gomega"
)

var _ = Describe("DRF Test", func() {
It("drf works", func() {
ctx := initTestContext(options{})
defer cleanupTestContext(ctx)

slot := oneCPU
rep := clusterSize(ctx, slot)
job := &jobSpec{
tasks: []taskSpec{
{
img: defaultNginxImage,
req: slot,
min: rep,
rep: rep,
},
},
}

job.name = "j1-reference"
referenceJob := createJob(ctx, job)
err := waitTasksReady(ctx, referenceJob, int(rep))
Expect(err).NotTo(HaveOccurred())

job.name = "j2-drf"
job.tasks[0].req = halfCPU
backfillJob := createJob(ctx, job)
err = waitTasksReady(ctx, backfillJob, int(rep))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate how drf work in this case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drf works when a task who requires less resource and to be schedulered will preempt resource of another task who require more resource and is running

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comments

Expect(err).NotTo(HaveOccurred())
})
})