Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proj03 - feedback #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Proj03 - feedback #10

wants to merge 2 commits into from

Conversation

AndreaVolkamer
Copy link
Member

@AndreaVolkamer AndreaVolkamer commented May 17, 2021

Description

Include feedback to project 03

Todos

  • Textual
  • Code

Questions

  • Check if the else clause in cell 9 is correct
  • Could you add some more info on how to use the interaction fingerprint functionalities (before cell 12)
  • Could you shortly discuss the main features found (e.g. hinge contact)
  • Could you add a visualization at the end (nglview, I think @jaimergp has an example in his project)?

Status

  • Ready to go

@AndreaVolkamer
Copy link
Member Author

@schallerdavid well done, thanks! I mostly added some text.
Could you have a look at the questions I mentioned above?

@schallerdavid
Copy link
Contributor

Hey @AndreaVolkamer ,

thanks for your feedback. All good comments and I would definitely add more details to the different sections. But I'd rather wait for our meeting to discuss where we wanna go with the project/paper.

The else clause in cell 9 is correct I think, but we can also talk about it in more detail during the next meeting.

David

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants