Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs CI fails #333

Closed
mbackenkoehler opened this issue Apr 25, 2023 · 4 comments · Fixed by #335
Closed

Docs CI fails #333

mbackenkoehler opened this issue Apr 25, 2023 · 4 comments · Fixed by #335
Assignees
Labels
bug Something isn't working ready-to-merge

Comments

@mbackenkoehler
Copy link
Collaborator

Currently, the Docs CI fails on the Sphinx 404 checks. Take this one, for example.

image

@dominiquesydow Any ideas for a quick fix?

@mbackenkoehler mbackenkoehler added the bug Something isn't working label Apr 25, 2023
@dominiquesydow
Copy link
Collaborator

dominiquesydow commented Apr 26, 2023

Hi @mbackenkoehler,

It seems like the URL checker that we have been using here (broken-link-checker) is no longer maintained:

npm WARN exec The following package was not found and will be installed: broken-link-checker@0.7.8
npm WARN deprecated calmcard@0.1.1: no longer maintained
npm WARN deprecated nopter@0.3.0: try optionator
npm WARN deprecated urlobj@0.0.11: use universal-url, minurl, relateurl, url-relation
npm WARN deprecated uuid@2.0.3: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
Error: Unhandled Rejection. Error: connect ECONNREFUSED ::1:8000
Error: Process completed with exit code 1.

Could you please try either the proposed package in the error message --- or try ´linkinator´ which we are using for our lab website:
https://github.com/volkamerlab/volkamerlab_org/blob/482d6cb15f4406c1b1863123efe8d5b294c1f7cd/.github/workflows/ci.yaml#L33

@mbackenkoehler mbackenkoehler self-assigned this Apr 26, 2023
@mbackenkoehler mbackenkoehler linked a pull request Apr 26, 2023 that will close this issue
3 tasks
@mbackenkoehler
Copy link
Collaborator Author

I switched to linkinator. This seems to work fine. (see #335 )

However, there are a quite a few dead links right now. I will open an separate issue for that.

@mbackenkoehler
Copy link
Collaborator Author

Broken links are collected in #336

@mbackenkoehler
Copy link
Collaborator Author

Docs CI fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready-to-merge
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants