Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead links #336

Closed
28 tasks done
mbackenkoehler opened this issue Apr 26, 2023 · 5 comments
Closed
28 tasks done

Dead links #336

mbackenkoehler opened this issue Apr 26, 2023 · 5 comments
Assignees

Comments

@mbackenkoehler
Copy link
Collaborator

mbackenkoehler commented Apr 26, 2023

As per the CI, the following links do not work. The 403 are rejections which can probably be added to the skips like doi.org. The 404 either moved or are gone. These need to be fixed manually.

  • [404] _static/images/apple-icon-152x152.png

external_dependencies.html

external_tutorials_collections.html

talktorials/T004_compound_similarity.html

talktorials/T005_compound_clustering.html

  • [404] talktorials/images/butina_full.pdf

talktorials/T011_query_online_api_webservices.html

talktorials/T012_query_klifs.html

talktorials/T013_query_pubchem.html

talktorials/T015_protein_ligand_docking.html

talktorials/T022_ligand_based_screening_neural_network.html

talktorials/T021_one_hot_encoding.html

talktorials/T009_compound_ensemble_pharmacophores.html

talktorials/T012_query_klifs.html

talktorials/T018_automated_cadd_pipeline.html

talktorials/T020_md_analysis.html

@mbackenkoehler
Copy link
Collaborator Author

@hamzaibrahim21 You can tick off the links you worked through here.

@hamzaibrahim21
Copy link
Collaborator

hamzaibrahim21 commented Apr 30, 2023

All links should be fixed except for the first error " [404] _static/images/apple-icon-152x152.png" ba8a4c8. Should I add an "apple-icon-152x152.png", because there is no such an image in mentioned directory, or just ignore the error?

@mbackenkoehler
Copy link
Collaborator Author

@hamzaibrahim21 That's great! Thanks! Yes, please add the appli-icon one. It should be safe to ignore.

@mbackenkoehler
Copy link
Collaborator Author

@hamzaibrahim21 Somehow a few new ones popped up for me. You can run the checks locally, following the job in the gh workflow.

Also, for local files you can check in docs/_build.html if everything built correctly. T005 is missing the butina figure, for example.

@hamzaibrahim21
Copy link
Collaborator

@mbackenkoehler All broken links are fixed by now 38709b2, please let me know if other links popped up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants